Add symfony profiler panel #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
force-pushed
the
profiler
branch
2 times, most recently
from
a69c381
to
c2ecd8d
Compare
Closed
goetas
force-pushed
the
profiler
branch
3 times, most recently
from
4e94df4
to
a78670e
Compare
goetas
force-pushed
the
profiler
branch
2 times, most recently
from
61f9981
to
e604727
Compare
|
Hey @goetas cool feature! I've just tested it. Can it be that calls to |
|
hmm. that can be, i do not remember testing that use case |
jdreesen
reviewed
Jun 29, 2022
Comment on lines
+24
to
+32
| protected function loadFileIfFound($prefix, $dir, \ReflectionClass $class, $extension) | ||
| { | ||
| $pathData = parent::loadFileIfFound($prefix, $dir, $class, $extension); | ||
|
|
||
| if ($pathData[0] !== null) { | ||
| $this->files[$class->getName()][$pathData[0]] = $pathData[1]; | ||
| } | ||
| return $pathData; | ||
| } |
There was a problem hiding this comment.
This is broken. It doesn't seem to refer to anything in this project, and seems to never be called, thus not logging anything. I fixed it in #894.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #852