Fix TraceableFileLocator
#894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scyzoryck
reviewed
Jul 1, 2022
jdreesen
force-pushed
the
fix-profiler-file-locator
branch
from
2e88111
to
0c653ae
Compare
scyzoryck
approved these changes
Jul 1, 2022
|
I think this is ready. |
|
im sorry if it took me this long to answer, could you please rebase this? |
jdreesen
force-pushed
the
fix-profiler-file-locator
branch
from
0c653ae
to
bb3eb6c
Compare
|
Sure, done. I don't think the CI failure is related to this PR. It's the same as in #893. |
|
Should be fixed by #901 |
|
Can this be considered a duplicate of #900? |
|
I'm not sure, I tend to no. |
jdreesen
force-pushed
the
fix-profiler-file-locator
branch
from
bb3eb6c
to
e56a30c
Compare
|
I'm sorry , now i remember what was this about. i forgot to commit it in the jms/metadata package. it was supposed to be a new feature that allows you to know which files were attempted to be loaded when looking for metadata ( a common problem i saw in many invalid bug reports). I will adjust it as soon as I can. Thanks! |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TraceableFileLocator, which was introduced in #858, to log some data for Symfony's profiler panel, was broken. It implemented a method that doesn't exist anywhere in the project and thus never gets called, so nothing is logged. In the profiler panel you may think everything's alright, though, as the messageif this list is empty, probably all the data are cached as expectedgets displayed, which is probably even true most of the time.The new
TraceableFileLocatornow also decorates the original one, instead of extending it, which makes it more flexible in case someone else wants to decorate theFileLocator, too.