Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony profiler page #852

Closed
wants to merge 7 commits into from
Closed

Symfony profiler page #852

wants to merge 7 commits into from

Conversation

gam6itko
Copy link
Contributor

@gam6itko gam6itko commented May 4, 2021

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets #812
License MIT

Adds data_collector to Symfony profiler.

Depends on schmittjoh/serializer#1316

Features:

  • collects profile data for every jms_serializer run.
  • collects profile data for all triggered and not triggered event listeners
  • collects profile data for all triggered and not triggered handlers
  • collects profile data for all loaded metadata via Annotation, Xml, Yaml drivers

I would appreciate any feedback

image

image

image

image

image

@gam6itko gam6itko marked this pull request as draft May 4, 2021 09:52
@gam6itko gam6itko marked this pull request as ready for review May 4, 2021 10:16
@goetas
Copy link
Collaborator

goetas commented Jun 21, 2021

The logo you have used is the one for http-plug, can you please use the jms logo? https://github.com/schmittjoh/serializer/blob/master/doc/logo.png

@goetas
Copy link
Collaborator

goetas commented Jul 5, 2021

@gam6itko FYI https://github.com/schmittjoh/serializer/releases/tag/3.13.0 has been released

@gam6itko gam6itko marked this pull request as draft July 5, 2021 20:08
@gam6itko
Copy link
Contributor Author

gam6itko commented Jul 5, 2021

should we up required "jms/serializer" to "^3.13"?

@goetas
Copy link
Collaborator

goetas commented Jul 6, 2021

should we up required "jms/serializer" to "^3.13"?

yes

@gam6itko gam6itko marked this pull request as ready for review July 6, 2021 16:56
@goetas goetas mentioned this pull request Jul 24, 2021
Merged
@goetas
Copy link
Collaborator

goetas commented Aug 6, 2021

replaced by #858

@goetas goetas closed this Aug 6, 2021
@gam6itko gam6itko deleted the symfony_profiler4 branch August 7, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas goetas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gam6itko @goetas