Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for data_collector #1316

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Conversation

gam6itko
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT

related to schmittjoh/JMSSerializerBundle#812

To allow DataCollector get information about triggered events and handlers I need these getters

Copy link
Collaborator

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to mark this methods as @internal, it is better to not expose them as part of the BC promise

@goetas goetas merged commit cd901ca into schmittjoh:master Jul 5, 2021
@goetas
Copy link
Collaborator

goetas commented Jul 5, 2021

@gam6itko thanks!

@gam6itko gam6itko deleted the symfony_profiler branch February 15, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants