Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI New Node Page] Add alerts table in Node Page #2775

Closed
ChengYanJin opened this issue Sep 4, 2020 · 3 comments · Fixed by #2868 or #2881
Closed

[UI New Node Page] Add alerts table in Node Page #2775

ChengYanJin opened this issue Sep 4, 2020 · 3 comments · Fixed by #2868 or #2881
Assignees
Labels
complexity:medium Something that requires one or few days to fix topic:ui UI-related issues

Comments

@ChengYanJin
Copy link
Contributor

ChengYanJin commented Sep 4, 2020

Component: ui, nodes

Why this is needed:

  • We want to see all the active alerts related to this node.
  • With the filter component to filter the alert base on severity.

What should be done:

  • We should retrieve the alerts from Alertmanager and list all the alerts in the table

  • When we add the severity filter the URL should update too.
    /newNodes/<node-name>/alerts?severity=<critical/warning>

  • Remove the info selector because we only have critical and warning for the moment for Node

  • if there is no severity selected then no alert display.

  • When we come to the alert tab from the tab selection, by default display all the alerts(both critical and warning)
    the URL should be: /newNodes/<node-name>/alerts?severity=critical,warning or
    or /newNodes/<node-name>/alerts?severity=critical&severity=warning

Implementation proposal (strongly recommended):

Update proposal
image

Hardcode the alerts related to nodes in frontend.

Store all the selected severity in an array

const selectedSeverity = [ ];

const [isCriticalSelected, setIsCriticalSelected] = useState();
const [isWarningSelected, setIsWarningSelected] = useState();

Test plan:
TBD

@ChengYanJin ChengYanJin added topic:ui UI-related issues complexity:easy Something that requires less than a day to fix labels Sep 4, 2020
@gdemonet
Copy link
Contributor

gdemonet commented Sep 7, 2020

Before implementing this, we need a detailed list of relevant alerts to look at, and how to retrieve them (which AM query we need to perform).

@ChengYanJin
Copy link
Contributor Author

ChengYanJin commented Sep 7, 2020

Before implementing this, we need a detailed list of relevant alerts to look at, and how to retrieve them (which AM query we need to perform).

Hello @gdemonet ,
We have around 20 preconfigured alert rules related to Node, please check Prometheus configuration

I was hoping to retrieve them from the /api/v1/alerts, I will check it.

@gdemonet
Copy link
Contributor

gdemonet commented Sep 7, 2020

We have around 20 preconfigured alert rules related to Node, please check Prometheus configuration

Indeed, I just think we should have the exhaustive list stated in this ticket.

I was hoping to retrieve them from the /api/v1/alerts, I will check it.

Should work fine for now (note that the current API under development is not v1, but v2 - see here). You would need to filter this list somehow, do you plan on getting all of them and filter in the browser, or use AM's features for this (recommended)?

Side-note (cc @alexandre-allard-scality @thomasdanan): there is an "alert grouping" feature which would probably make a lot of sense to let the UI "know" what to retrieve without caring for the detailed list (mentioned above) of alert rules to consider.

@ChengYanJin ChengYanJin added complexity:medium Something that requires one or few days to fix and removed complexity:easy Something that requires less than a day to fix labels Sep 30, 2020
@ChengYanJin ChengYanJin self-assigned this Oct 1, 2020
ChengYanJin added a commit that referenced this issue Oct 1, 2020
ChengYanJin added a commit that referenced this issue Oct 1, 2020
ChengYanJin added a commit that referenced this issue Oct 1, 2020
There are two parameters to filter the alert for the specific node: alertname and instanceIP

Refs: #2775
ChengYanJin added a commit that referenced this issue Oct 1, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
In order to the childrens to retrieve alerts

Refs: #2775
ChengYanJin added a commit that referenced this issue Oct 16, 2020
The circle next to the Node Name should depend on the health

Refs: #2775
ChengYanJin added a commit that referenced this issue Oct 16, 2020
Fix the bug of URL when click on the tab

Refs: #2775
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
ChengYanJin added a commit that referenced this issue Oct 16, 2020
In order to the childrens to retrieve alerts

Refs: #2775
ChengYanJin added a commit that referenced this issue Oct 16, 2020
The circle next to the Node Name should depend on the health

Refs: #2775
ChengYanJin added a commit that referenced this issue Oct 16, 2020
Fix the bug of URL when click on the tab

Refs: #2775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:medium Something that requires one or few days to fix topic:ui UI-related issues
Projects
None yet
2 participants