-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI New Node Page] Add alerts table in Node Page #2775
Comments
Before implementing this, we need a detailed list of relevant alerts to look at, and how to retrieve them (which AM query we need to perform). |
Hello @gdemonet , I was hoping to retrieve them from the |
Indeed, I just think we should have the exhaustive list stated in this ticket.
Should work fine for now (note that the current API under development is not v1, but v2 - see here). You would need to filter this list somehow, do you plan on getting all of them and filter in the browser, or use AM's features for this (recommended)? Side-note (cc @alexandre-allard-scality @thomasdanan): there is an "alert grouping" feature which would probably make a lot of sense to let the UI "know" what to retrieve without caring for the detailed list (mentioned above) of alert rules to consider. |
There are two parameters to filter the alert for the specific node: alertname and instanceIP Refs: #2775
In order to the childrens to retrieve alerts Refs: #2775
The circle next to the Node Name should depend on the health Refs: #2775
Fix the bug of URL when click on the tab Refs: #2775
In order to the childrens to retrieve alerts Refs: #2775
The circle next to the Node Name should depend on the health Refs: #2775
Fix the bug of URL when click on the tab Refs: #2775
Component: ui, nodes
Why this is needed:
What should be done:
We should retrieve the alerts from
Alertmanager
and list all the alerts in the tableWhen we add the severity filter the URL should update too.
/newNodes/<node-name>/alerts?severity=<critical/warning>
Remove the info selector because we only have critical and warning for the moment for Node
if there is no severity selected then no alert display.
When we come to the alert tab from the tab selection, by default display all the alerts(both critical and warning)
the URL should be:
/newNodes/<node-name>/alerts?severity=critical,warning
oror
/newNodes/<node-name>/alerts?severity=critical&severity=warning
Implementation proposal (strongly recommended):
Update proposal

Hardcode the alerts related to nodes in frontend.
Store all the selected severity in an array
const selectedSeverity = [ ];
const [isCriticalSelected, setIsCriticalSelected] = useState();
const [isWarningSelected, setIsWarningSelected] = useState();
Test plan:
TBD
The text was updated successfully, but these errors were encountered: