[Integration branch]To merge all Node PRs #2881

ChengYanJin · 2020-10-20T09:36:52Z

Component: ui, nodes

Context:
The integration branch with all the Node Page PRs to be merged.

Summary:
The new commits that do not cover in the open PRs

Rename from /newNodes to /nodes
Auto select the first node in the list when hit URL /nodes
Add Advanced Metrics button in Metrics. (Need to figure out how to redirect to the dashboard specific for this node)
Retrieve unode-name from Prometheus in order to be redirect to the right Node Detailed dashboard in Grafana

Acceptance criteria:
Overview Tab:

Metrics Tab:

Volume Tab:

Pod Tab:

Detail Tab:

Closes: #2877
Closes: #2775
Closes: #2791
Closes: #2777
Closes: #2802

- Update the dark mode with final version - Update the status color of light mode with proposal, but keep the primary/text/border as the previous version, since it doesn't work well.

Refs: #2775

In order to the childrens to retrieve alerts Refs: #2775

The circle next to the Node Name should depend on the health Refs: #2775

Fix the bug of URL when click on the tab Refs: #2775

Refs: #2791

…loying Refs: #2791

Refs: #2791

Ref: #2791

- Update the dark mode with final version - Update the status color of light mode with proposal, but keep the primary/text/border as the previous version, since it doesn't work well.

Out of the scope of this PR: Since we update the color-palette, there is some sightly changes in order to align with the design Refs: #2791

…e design Out of the scope of this PR Refs: #2791

Refs: #2775

Refs: #2777

We used to copy-paste the contents of the ui/public/brand/theme.json file to this ConfigMap manifest. To make sure we never forget about it nor make any mistake when copying, we switch to templating this manifest from the contents of the original file.

…hart Refs: #2776

Refs: #2776

- When switch bwtween the nodes, keep the same tab, and same timespan if metric tab is selected - When switch bwtween the nodes, if there no tab selected, by default `health` tab is selected Refs: #2776

Fix the bug of progressbar in core-ui Refs: #2777

Todo: Need to work on the path before change the URL back to /volumes Refs: #2777

Refs: #2777

… tab

thomasdanan

Excellent !!!

I noticed few things:

the advanced metrics link (in metrics tab) was not bringing me to the right node instance
If I click on Create Node and Cancel, the node selection from where I was coming from is lost.
still see the little bug about capacity usage bar
I realize that it is not obvious that one node is having one Volume which is in Critical state. We may want this to appear in the tab header (more or less like we do for alerts: displaying number of Volumes and maybe number of volumes in critical health) => probably another improvement ticket
If I search a node with some free text in the search bar, then if I select a node and start navigating through the tabs, the search filter is not applied anymore (and is removed from url)
ideally, the up/down arrow key should let the user switching from one node to another

bert-e · 2020-10-20T13:46:18Z

History mismatch

Merge commit #0435bddbf1ba7373563bb55fba5079fef6b3ba61 on the integration branch
w/2.7/feature/integration-branch-to-merge-all-node-prs is merging a branch which is neither the current
branch feature/integration-branch-to-merge-all-node-prs nor the development branch
development/2.7.

It is likely due to a rebase of the branch feature/integration-branch-to-merge-all-node-prs and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

…etailed dashboard in Grafana

ChengYanJin · 2020-10-21T08:01:39Z

Hi @thomas,
Thanks for the early feedback!

I fixed the bugs/issues you raised in the comments.
But not these two bullet points. I will create tickets to track them.

I realize that it is not obvious that one node is having one Volume which is in Critical state. We may want this to appear in the tab header (more or less like we do for alerts: displaying number of Volumes and maybe number of volumes in critical health) => probably another improvement ticket
ideally, the up/down arrow key should let the user switching from one node to another

ChengYanJin · 2020-10-23T09:36:24Z

/reset

bert-e · 2020-10-23T09:36:32Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2020-10-23T09:36:41Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/integration-branch-to-merge-all-node-prs into
development/2.6
w/2.7/feature/integration-branch-to-merge-all-node-prs will be merged into development/2.7

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-10-23T09:36:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2020-10-23T11:09:51Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin · 2020-10-23T11:57:54Z

/approve

bert-e · 2020-10-23T11:58:04Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.6
✔️ development/2.7

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2020-10-23T14:25:37Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.6
✔️ development/2.7

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5

Please check the status of the associated issue None.

Goodbye chengyanjin.

ChengYanJin and others added 30 commits October 14, 2020 17:21

ui/theme: Update the them for light/dark mode

887ee57

- Update the dark mode with final version - Update the status color of light mode with proposal, but keep the primary/text/border as the previous version, since it doesn't work well.

ui/constents: Hardcode all the alerts for Node

31e8a6a

Refs: #2775

ui/nodes: Changes based on common components from Alex

0455cdb

Refs: #2775

ui/translation: Update the translation for active alerts

702f1f7

Refs: #2775

ui/constants: Add the constant for the size of the circle

d5de167

Refs: #2775

ui/circleStatus: Update the color of the status based on the new design

778b284

Refs: #2775

ui/nodes: Retrieve the health for node in NodeUtils

db796a1

Refs: #2775

ui/nodes: Clean the code in NodeListTable

bcc52f0

Refs: #2775

ui/nodes: Add Alert tab for Node

ac46430

Refs: #2775

ui/nodes: Add refreshAlert in NodePageContent

5b5180e

In order to the childrens to retrieve alerts Refs: #2775

ui/nodes: Add alert component in Overview tab

ae01732

The circle next to the Node Name should depend on the health Refs: #2775

ui/nodes: Fetch the alert for NodeAlertTab in NodePageRSP

9c1ba50

Fix the bug of URL when click on the tab Refs: #2775

ui/theme: Cherry-pick the update of theme.json

dfb5b82

ui/nodes: Add the deploy status & update the statusTextColor

0ae004c

Refs: #2791

ui/nodes: Remove the CP and WP in the Node Table when the Node is dep…

3b1c439

…loying Refs: #2791

ui/nodes: Add node deployment in overview tab

0391700

Refs: #2791

ui/styles: Add padding for the tab

a5b601c

Ref: #2791

ui/theme: Update the them for light/dark mode

ef14f89

- Update the dark mode with final version - Update the status color of light mode with proposal, but keep the primary/text/border as the previous version, since it doesn't work well.

ui/styles: Update the color of the log icon

9cf4e33

Out of the scope of this PR: Since we update the color-palette, there is some sightly changes in order to align with the design Refs: #2791

ui/styles: Update the style of NodeListTable and Tabs according to th…

148f562

…e design Out of the scope of this PR Refs: #2791

ui/nodes: Remove the baseLink for the two alerts reuse component

29bc93f

Refs: #2775

ui/salt: Update the theme.json in configMap

377de54

Refs: #2777

ui/nodes: Extract the common y-axis specification for vega-lite linec…

4f3d761

…hart Refs: #2776

ui/nodes/metrics: Add timespan selection for the graphs

5267c8e

Refs: #2776

ui/nodes: Add the selected timespan in the URL

f438c63

- When switch bwtween the nodes, keep the same tab, and same timespan if metric tab is selected - When switch bwtween the nodes, if there no tab selected, by default `health` tab is selected Refs: #2776

ui/package: Update the core-ui version

c499076

Fix the bug of progressbar in core-ui Refs: #2777

ui/nodes: Add temporary else if to get the node name from URL

99e331e

Todo: Need to work on the path before change the URL back to /volumes Refs: #2777

ui/nodes: Fill the volume tab in New Node Page

3be3f03

Refs: #2777

ui/nodes: Adapt the volumelistTable to be used by Node Page

68e8def

Refs: #2777

ui/styles: Add the padding top for advanced metrics button in metrics…

1e28ea1

… tab

thomasdanan reviewed Oct 20, 2020

View reviewed changes

ChengYanJin force-pushed the feature/integration-branch-to-merge-all-node-prs branch from b42e062 to efcd7cc Compare October 20, 2020 13:46

ChengYanJin added 2 commits October 20, 2020 15:46

ui/nodes: Bugfix when click on the tab lose the querystring

33695a5

ui/nodes: History.goback() when click on the cancel button

efcd7cc

ChengYanJin force-pushed the feature/integration-branch-to-merge-all-node-prs branch from 8741ff4 to 04bbf54 Compare October 21, 2020 07:32

ui/nodes: Retrieve the Hostname label to redirect to the right Node D…

04bbf54

…etailed dashboard in Grafana

thomasdanan previously approved these changes Oct 21, 2020

View reviewed changes

ChengYanJin added the topic:ui UI-related issues label Oct 21, 2020

ChengYanJin dismissed thomasdanan’s stale review via eaa7af9 October 21, 2020 16:52

ChengYanJin force-pushed the feature/integration-branch-to-merge-all-node-prs branch 3 times, most recently from eff6a50 to 72e7a29 Compare October 22, 2020 05:57

ui/tests: Adapt the E2E test Node.feature for the new node page

72e7a29

thomasdanan approved these changes Oct 23, 2020

View reviewed changes

bert-e merged commit 6494107 into development/2.6 Oct 23, 2020

bert-e deleted the feature/integration-branch-to-merge-all-node-prs branch October 23, 2020 14:25

This was referenced Oct 23, 2020

[UI New Node Page] Add Details tab in Node Page #2843

Closed

New Node Page Layout #2640

Closed

[UI New Node Page]Add Detail tab in the new node page #2821

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Integration branch]To merge all Node PRs #2881

[Integration branch]To merge all Node PRs #2881

ChengYanJin commented Oct 20, 2020 •

edited

Loading

thomasdanan left a comment

bert-e commented Oct 20, 2020

ChengYanJin commented Oct 21, 2020

ChengYanJin commented Oct 23, 2020

bert-e commented Oct 23, 2020

bert-e commented Oct 23, 2020

bert-e commented Oct 23, 2020

bert-e commented Oct 23, 2020

ChengYanJin commented Oct 23, 2020

bert-e commented Oct 23, 2020

bert-e commented Oct 23, 2020

[Integration branch]To merge all Node PRs #2881

[Integration branch]To merge all Node PRs #2881

Conversation

ChengYanJin commented Oct 20, 2020 • edited Loading

thomasdanan left a comment

Choose a reason for hiding this comment

bert-e commented Oct 20, 2020

History mismatch

ChengYanJin commented Oct 21, 2020

ChengYanJin commented Oct 23, 2020

bert-e commented Oct 23, 2020

Reset complete

bert-e commented Oct 23, 2020

Integration data created

bert-e commented Oct 23, 2020

Waiting for approval

bert-e commented Oct 23, 2020

Waiting for approval

ChengYanJin commented Oct 23, 2020

bert-e commented Oct 23, 2020

In the queue

bert-e commented Oct 23, 2020

ChengYanJin commented Oct 20, 2020 •

edited

Loading