Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add alert tab in the new node page #2868

Merged

Conversation

ChengYanJin
Copy link
Contributor

Component: ui, nodes

Context: Add alerts for Node page.

Summary:

  • Add active alert in Alert Tab
  • Reuse the <ActiveAlertFilter/> component from @alexis-ld to filter the alerts base on severity.
  • Reuse the <ActiveAlertsCounter/> component from @alexis-ld to display the alerts in Overview tab and be able to redirect to the Alert tab
  • Update the theme.json base on the final dark-theme color-palette.

Acceptance criteria:
image
image


Closes: #2775

@ChengYanJin ChengYanJin requested a review from a team as a code owner October 16, 2020 10:51
@bert-e
Copy link
Contributor

bert-e commented Oct 16, 2020

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 16, 2020

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Oct 16, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

thomasdanan
thomasdanan previously approved these changes Oct 16, 2020
Copy link
Contributor

@thomasdanan thomasdanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent !!!

If I had one thing to change, I would suggest improving the alert severity selector. We may want to tackle this improvement later on, in one other ticket.

@bert-e bert-e merged commit 2ae3b50 into development/2.6 Oct 23, 2020
@bert-e bert-e deleted the improvement/2775-add-alert-tab-in-the-new-node-page branch October 23, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI New Node Page] Add alerts table in Node Page
3 participants