Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ammonite to support Scala 2.12.13 #2530

Closed
wants to merge 1 commit into from
Closed

Update Ammonite to support Scala 2.12.13 #2530

wants to merge 1 commit into from

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Feb 19, 2021

Fixes #2392

ckipp01
ckipp01 approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to have this fixed. LGTM!

ckipp01
ckipp01 requested changes Feb 20, 2021
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually sorry looking closer I totally missed that the Ammonite LSP tests were failing. We'll need to figure out what's going on with these releases...

@tgodzik
Copy link
Contributor Author

tgodzik commented Feb 20, 2021

Actually sorry looking closer I totally missed that the Ammonite LSP tests were failing. We'll need to figure out what's going on with these releases...

Yeah, I noticed that something seems off. I will investigate next week.

@tgodzik tgodzik closed this Feb 20, 2021
@alexarchambault
Copy link
Contributor

I think the issue lies in ammonite-runner. It needs to pull amm-compiler along the other Ammonite dependencies it fetches, because of com-lihaoyi/Ammonite#1144.

@tgodzik
Copy link
Contributor Author

tgodzik commented Feb 24, 2021

I think the issue lies in ammonite-runner. It needs to pull amm-compiler along the other Ammonite dependencies it fetches, because of com-lihaoyi/Ammonite#1144.

@alexarchambault do you need any help with that?

@alexarchambault
Copy link
Contributor

That should be fine, thanks! ammonite-runner 0.3.1 should be on its way to Maven Central. I didn't try, but it ought to fix the errors we're seeing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ammonite for 2.13.5
3 participants
@tgodzik @alexarchambault @ckipp01