Move compiler-related stuff to a new compiler module #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
compiler-module
branch
5 times, most recently
from
f64902f to
c417431
Compare
That makes it easier later on to extract an interface for CompilerLifecycleManager
A simple Option is enough, and that makes for a cleaner interface for CompilerLifecycleManager later on.
Having it rely on Frame from ammonite.repl.api, rather than a concrete Frame implementation, makes it easier to extract an interface for CompilerLifecycleManager later on.
…and remove Compiler.parse This allows to strip the Compiler public API of references to scala.tools.nsc. Later on, makes it easier to extract an interface for Compiler.
This makes it more straightforward to extract an API for parsing later on.
Just like the previous commit, this facilitates extracting an API for parsing later on.
alexarchambault
force-pushed
the
compiler-module
branch
from
c417431 to
9ad9655
Compare
util will be a shared dependency of runtime / interp on the one hand, and the upcoming compiler module on the other. Moving Classpath here allows it to be used by both.
So that they can be used from the compiler module
It's used both from repl and compiler, which won't depend on each other in subsequent commits.
So that these can have different signatures in Scala 3, and we can drop the dependency on compiler from interp and repl.
alexarchambault
force-pushed
the
compiler-module
branch
from
9ad9655 to
a99b0da
Compare
|
Looks good to me, feel free to merge whenever |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subsumes #1135. The core idea of this PR consists in moving any compiler- or parsing-related logic to a new
compilermodule, that we can rewrite for Scala 3 later on.Thanks to the 2.13 / 3 compatibility, we can just rewrite this
compilermodule in Scala 3 in a first time, and run it alongside the other modules compiled for 2.13, to get Scala 3 support. This is done on this branch (I'm about to add details about what it can and cannot do in its README).This PR also adds a new
compiler-interfacemodule, defining a few compiler- and parsing-related traits, and hasinterpandrepldepend on those traits rather than on the classes ofcompiler. This ensures we don't inadvertently depend on concrete scalac or fastparse definitions orcompilerinternals frominterpandrepl, which would hamper substitutingcompilertargetting Scala 3 tocompilertargetting Scala 2.13 at runtime.In more detail, the commits in this PR successively:
compilermodule and move code to it,compiler-interfacemodule, with mostly just traits,compiler-interfaceincompiler,compiler-interfacerather thancompilerininterp, then inrepl.Commit-by-commit:
CompilerLifecycleManagerAPIParsersAPIutil- asinterpandcompilerultimately don't depend on each other, we move some classes they both use inutilcompilercompiler-interface, implement its traits incompilerinterpandcompilerreplandcompiler