Fix --bsp #1146
Merged
Fix --bsp #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
fix-bsp
branch
from
010de4b to
c78ab75
Compare
tgodzik
approved these changes
Jan 18, 2021
|
@alexarchambault would it be possible to release a new version with the fix? |
|
My bad, I thought the CI release jobs would have passed since then :| It seems I can't re-run these jobs, maybe because they're too old now. I just merged #1143, hoping it'll work this time. |
|
Ok, it failed again (timeout from mill), but I was able to manually release stuff from the Sonatype UI. Just waiting for the sync to Central now. |
|
Awesome! Thanks! |
|
Trying it out here https://github.com/scalameta/metals/pull/2530/files ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #1144, reported in 959a053#r46029299.