Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ammonite for 2.13.5 #2392

Closed
tgodzik opened this issue Jan 15, 2021 · 3 comments · Fixed by #2632
Closed

Update ammonite for 2.13.5 #2392

tgodzik opened this issue Jan 15, 2021 · 3 comments · Fixed by #2632
Labels
tech debt We should have addressed this yesterday
Milestone
Metals v0.10.1

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Jan 15, 2021 •
edited
Loading

Currently we test Ammonite support on 2.12.12, but as soon as it's available for 2.12.13, we should switch.

Once we do it we should:

  • move Ammonite212 suite back to unit tests and set V.scala212 version
  • remove 2.12.12 from publishAllMtags invocation in build.sbt
@tgodzik tgodzik added the tech debt We should have addressed this yesterday label Jan 15, 2021
@alexarchambault
Copy link
Contributor

Ammonite for 2.12.13 has just been published (it should have been published earlier, something went wrong in its release jobs…).

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 16, 2021

Awesome, thanks! I will update the PR then.

@tgodzik tgodzik mentioned this issue Feb 19, 2021
Closed
@tgodzik
Copy link
Contributor Author

tgodzik commented Feb 24, 2021

2.12.13 is now supported, but we now are missing 2.13.5, which is not yet released.

@ckipp01 ckipp01 changed the title Update ammonite for 2.12.13 Update ammonite for 2.13.5 Feb 26, 2021
@ckipp01 ckipp01 mentioned this issue Mar 25, 2021
Merged
@tgodzik tgodzik added this to the Metals v0.10.1 milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt We should have addressed this yesterday
Projects
None yet
Milestone
Metals v0.10.1
2 participants
@tgodzik @alexarchambault