-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show organization in dataset info tab #7087
Conversation
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx
Outdated
Show resolved
Hide resolved
@philippotto right now I left the check for equality inverted because I am not sure how include another organizations dataset in my users dataset list view. Of course, for the final check, this needs to be put right. I feel like everything else is working as I expect it, so I am requesting a review already :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice :) I left some feedback and will test now.
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx
Outdated
Show resolved
Hide resolved
Great :) Please invert the conditions where necessary and then I'll do a final test before we merge the pr. |
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: [Docs] Update embedded YouTube URLs (#7102) Show organization in dataset info tab (#7087) Added Tutorials to Docs (#7095) Combine both download modals into one (#7068) Add "merge" blend mode (#6936) Changed the spacing/width of VX reports runs selection (#7094) Allow dataset managers to see all workflow reports of their orga (#7081) Fix rectangle at 0,0,0 (#7088) Allow to disable automatic reloading of meshes during proofreading (#7076)
Steps to test:
Then, switch back to the first account (or do this beforehand) and make a dataset public via the dataset settings. Then, open the dataset url with the second account so that the base condition is met. (credits to @philippotto for this description)
-- In the dataset list view, after clicking on a dataset.
-- When viewing the dataset in the dataset info tab on the right.
-- When viewing or creating an annotation, again in the dataset info tab.
Issues:
(Please delete unneeded items, merge only when none are left open)
Updated documentation if applicabledoesnt seem applicable