Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dataset managers to see all workflow reports of their orga #7081

Merged
merged 4 commits into from
May 23, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 16, 2023

Steps to test:

  • set up voxelyticsEnabled locally, run voxelytics workflow
  • promote sample user 2 to dataset manager, log in as sample user 2. should see the workflow

Issues:

TODO:

Currently, the whole administration menu is hidden for non-team-managers. @philippotto do you think it would make sense to show it to dataset managers (that are not team managers)? Otherwise, the voxelytics workflows link is not visible to them


@fm3 fm3 added the backend label May 16, 2023
@fm3 fm3 requested a review from normanrz May 16, 2023 10:15
@fm3 fm3 self-assigned this May 16, 2023
@normanrz
Copy link
Member

Currently, the whole administration menu is hidden for non-team-managers. @philippotto do you think it would make sense to show it to dataset managers (that are not team managers)? Otherwise, the voxelytics workflows link is not visible to them

We could also move the Voxelytics workflow list to the dashboard

@philippotto
Copy link
Member

Currently, the whole administration menu is hidden for non-team-managers. @philippotto do you think it would make sense to show it to dataset managers (that are not team managers)? Otherwise, the voxelytics workflows link is not visible to them

We could also move the Voxelytics workflow list to the dashboard

Do you mean that there would be an additional tab in the dashboard for the voxelytics page? Or only a sub menu item in the "Dashboard" menu in the navbar?

Currently, the whole administration menu is hidden for non-team-managers. @philippotto do you think it would make sense to show it to dataset managers (that are not team managers)? Otherwise, the voxelytics workflows link is not visible to them

Yes, I think, it's okay. Any chance there is another category, too, that should be accessible by dataset managers? Then, the menu wouldn't consist of a single item.

@normanrz
Copy link
Member

normanrz commented May 17, 2023

Do you mean that there would be an additional tab in the dashboard for the voxelytics page? Or only a sub menu item in the "Dashboard" menu in the navbar?

I was thinking of a new tab. It doesn't really make sense under "Administration", so it needs a new home. But no strong opinion.

@philippotto
Copy link
Member

@philippotto do you think it would make sense to show it to dataset managers (that are not team managers)?

I just pushed a change which does this. Additionally, voxelytics jobs are visible to dataset managers.

Do you mean that there would be an additional tab in the dashboard for the voxelytics page? Or only a sub menu item in the "Dashboard" menu in the navbar?

I was thinking of a new tab. It doesn't really make sense under "Administration", so it needs a new home. But no strong opinion.

I'm not against that, but I went with the simpler route for now.

@philippotto philippotto merged commit 4b2e928 into master May 23, 2023
@philippotto philippotto deleted the dataset-managers-list-reports branch May 23, 2023 08:24
hotzenklotz added a commit that referenced this pull request May 31, 2023
…ty-list-drawings

* 'master' of github.com:scalableminds/webknossos:
  [Docs] Update embedded YouTube URLs (#7102)
  Show organization in dataset info tab (#7087)
  Added Tutorials to Docs (#7095)
  Combine both download modals into one (#7068)
  Add "merge" blend mode (#6936)
  Changed the spacing/width of VX reports runs selection (#7094)
  Allow dataset managers to see all workflow reports of their orga (#7081)
  Fix rectangle at 0,0,0 (#7088)
  Allow to disable automatic reloading of meshes during proofreading (#7076)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants