Combine both download modals into one #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
reviewed
May 15, 2023
frontend/javascripts/oxalis/view/action-bar/download_modal_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/action-bar/download_modal_view.tsx
Outdated
Show resolved
Hide resolved
daniel-wer
reviewed
May 16, 2023
There was a problem hiding this comment.
The general functionality worked very well, I also successfully tested the export 👍
- I noticed some issues where "annotation" appears in the "Download Dataset" modal that should be fixed:
- In the annotation download code, the indentation depth seems wrong for some lines
Co-authored-by: Daniel <[email protected]>
…bknossos into combine-download-modals
…bine-download-modals
…ot an annotation)
daniel-wer
approved these changes
May 17, 2023
frontend/javascripts/oxalis/view/action-bar/download_modal_view.tsx
Outdated
Show resolved
Hide resolved
hotzenklotz
added a commit
that referenced
this pull request
May 31, 2023
…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: [Docs] Update embedded YouTube URLs (#7102) Show organization in dataset info tab (#7087) Added Tutorials to Docs (#7095) Combine both download modals into one (#7068) Add "merge" blend mode (#6936) Changed the spacing/width of VX reports runs selection (#7094) Allow dataset managers to see all workflow reports of their orga (#7081) Fix rectangle at 0,0,0 (#7088) Allow to disable automatic reloading of meshes during proofreading (#7076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr combines the two download modals by merging the python modal that was used in the dataset view mode. The only python modal was deleted afterward.
The download modal now supports tiff export in view mode but not wkw download because there is no annotation to download from view mode.
For the review, I suggest turning off showing changes in whitespace. This will drastically decrease the number of changed lines.
URL of deployed dev instance (used for testing):
Steps to test:
yarn enable-jobsand start a local wk worker. ( <-- needed to test whether the tiff export works)download_modal_view.tsxand decrease the max limit 112 to something small by e.g. replacing the value that is compared to the variablevolumewith1000. Reloading and reopening the dataset should show the tiff export modal tab but the download should be disabled, as the layer is too large.Issues:
(Please delete unneeded items, merge only when none are left open)