Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore and view Neuroglancer Precomputed image volumes #6716

Merged
merged 29 commits into from
Feb 9, 2023
Merged

Conversation

@frcroth frcroth force-pushed the precomputed branch 2 times, most recently from 308d9f2 to c4d35a3 Compare January 27, 2023 13:27
@frcroth frcroth requested a review from fm3 February 3, 2023 11:03
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks really good! 🎉 I’m looking forward to using it :) I added a few comments, but nothing major. I’ll test this after you had a look at the suggestions. Could you also add a changelog entry and provide some steps to test?

Also, what is Fix janelia_flyem_hemibrain about in the PR description?

Concerning the compressedseg: do you know how this is solved for javascript? If writing java bindings is complicated, maybe we can do this as a separate PR in order not to keep this one open for too long.

Let’s talk about segmentation layer path issues in person

@frcroth
Copy link
Member Author

frcroth commented Feb 6, 2023

Compressed segmentation TS implementation can be found here: https://github.com/google/neuroglancer/tree/master/src/neuroglancer/sliceview/compressed_segmentation, the one used in wk-connect is here: https://github.com/seung-lab/compressedseg

@frcroth frcroth marked this pull request as ready for review February 6, 2023 16:12
@frcroth frcroth changed the title WIP: Support Neuroglancer Precomputed dataformat Support viewing Neuroglancer Precomputed volumes Feb 6, 2023
@frcroth frcroth changed the title Support viewing Neuroglancer Precomputed volumes Viewing and exploring of Neuroglancer Precomputed volumes Feb 6, 2023
@frcroth frcroth changed the title Viewing and exploring of Neuroglancer Precomputed volumes Explore and view Neuroglancer Precomputed image volumes Feb 6, 2023
@fm3
Copy link
Member

fm3 commented Feb 7, 2023

@philippotto could you please have a quick look at the front-end changes?

@fm3 fm3 requested a review from philippotto February 7, 2023 09:21
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front-end looks good 👍 Didn't test anything, though.

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💯

@frcroth frcroth merged commit 5b7ea7a into master Feb 9, 2023
@frcroth frcroth deleted the precomputed branch February 9, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read neuroglancer precomputed
4 participants