-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore and view Neuroglancer Precomputed image volumes #6716
Conversation
308d9f2
to
c4d35a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks really good! 🎉 I’m looking forward to using it :) I added a few comments, but nothing major. I’ll test this after you had a look at the suggestions. Could you also add a changelog entry and provide some steps to test?
Also, what is Fix janelia_flyem_hemibrain
about in the PR description?
Concerning the compressedseg: do you know how this is solved for javascript? If writing java bindings is complicated, maybe we can do this as a separate PR in order not to keep this one open for too long.
Let’s talk about segmentation layer path issues in person
util/src/main/scala/com/scalableminds/util/geometry/BoundingBox.scala
Outdated
Show resolved
Hide resolved
...ossos-datastore/app/com/scalableminds/webknossos/datastore/models/datasource/DataLayer.scala
Outdated
Show resolved
Hide resolved
...calableminds/webknossos/datastore/datareaders/precomputed/PrecomputedCompressorFactory.scala
Outdated
Show resolved
Hide resolved
...re/app/com/scalableminds/webknossos/datastore/datareaders/precomputed/PrecomputedArray.scala
Outdated
Show resolved
Hide resolved
...e/app/com/scalableminds/webknossos/datastore/datareaders/precomputed/PrecomputedHeader.scala
Outdated
Show resolved
Hide resolved
Compressed segmentation TS implementation can be found here: https://github.com/google/neuroglancer/tree/master/src/neuroglancer/sliceview/compressed_segmentation, the one used in wk-connect is here: https://github.com/seung-lab/compressedseg |
@philippotto could you please have a quick look at the front-end changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Front-end looks good 👍 Didn't test anything, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 💯
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Follow-up Issues