Fix nml upload by providing process browser shim #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
approved these changes
Jan 24, 2022
Will be tricky probably, since we would also need to run the webpack output in node then to validate the webpack configuration.. |
hotzenklotz
added a commit
that referenced
this pull request
Jan 27, 2022
* 'master' of github.com:scalableminds/webknossos: fix positioning of clip button (#5992) Honor mappingStatus when requesting to compute meshes ad-hoc (#5982) Add UI to globalize incomplete floodfill(s) (#5905) Add auto scaling for color layer (#5961) Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983) Fix dashboard refresh button behaviour (#5971) Update nanoid, trim-off-newlines and node-fetch (#5979) Add Arthur’s Alias in Build Notification Script (#5943) fix nml upload by providing process browser shim (#5987)
hotzenklotz
added a commit
that referenced
this pull request
Feb 3, 2022
…ossos into delete_tree_shortcut * 'delete_tree_shortcut' of github.com:scalableminds/webknossos: Add option to change active segement (#6006) ship expanded testdata (#6004) Allow Download of Public Annotations While Logged Out (#6001) Increase maximum bucket count limit for segmentation layers (#6000) Allow cancelling uploads (#5958) Store layer visibility with annotation (#5967) Fix async volume bugs (#5955) fix positioning of clip button (#5992) Honor mappingStatus when requesting to compute meshes ad-hoc (#5982) Add UI to globalize incomplete floodfill(s) (#5905) Add auto scaling for color layer (#5961) Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983) Fix dashboard refresh button behaviour (#5971) Update nanoid, trim-off-newlines and node-fetch (#5979) Add Arthur’s Alias in Build Notification Script (#5943) fix nml upload by providing process browser shim (#5987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The saxophone library depends on a library that accesses node's process dependency even when in the browser. Related to the webpack upgrade, since webpack no longer auto-provides these node polyfills.
Unfortunately, the nml parsing tests didn't catch this since they are executed in node. Ideally we could configure ava (or babel?) to simulate a browser environment and not include the node globals 🤔
URL of deployed dev instance (used for testing):
Steps to test:
(Please delete unneeded items, merge only when none are left open)