Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard refresh button behaviour #5971

Merged
merged 8 commits into from
Jan 26, 2022

Conversation

Dagobert42
Copy link
Contributor

Steps to test:

  1. use the refresh button in dashboard
  2. change contents of binaryData folder then 1.

Issues:


  • [✓] Ready for review

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool that you fought through this issue 👍 The solution looks good. I only have a minor suggestion regarding the tooltip.

frontend/javascripts/dashboard/dataset_view.js Outdated Show resolved Hide resolved
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent :)

@philippotto philippotto enabled auto-merge (squash) January 26, 2022 09:09
@philippotto philippotto merged commit 97e372c into master Jan 26, 2022
@philippotto philippotto deleted the fix-dashboard-refresh-button-behaviour branch January 26, 2022 09:43
hotzenklotz added a commit that referenced this pull request Jan 27, 2022
* 'master' of github.com:scalableminds/webknossos:
  fix positioning of clip button (#5992)
  Honor mappingStatus when requesting to compute meshes ad-hoc (#5982)
  Add UI to globalize incomplete floodfill(s) (#5905)
  Add auto scaling for color layer (#5961)
  Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983)
  Fix dashboard refresh button behaviour (#5971)
  Update nanoid, trim-off-newlines and node-fetch (#5979)
  Add Arthur’s Alias in Build Notification Script (#5943)
  fix nml upload by providing process browser shim (#5987)
hotzenklotz added a commit that referenced this pull request Feb 3, 2022
…ossos into delete_tree_shortcut

* 'delete_tree_shortcut' of github.com:scalableminds/webknossos:
  Add option to change active segement (#6006)
  ship expanded testdata (#6004)
  Allow Download of Public Annotations While Logged Out (#6001)
  Increase maximum bucket count limit for segmentation layers (#6000)
  Allow cancelling uploads (#5958)
  Store layer visibility with annotation (#5967)
  Fix async volume bugs (#5955)
  fix positioning of clip button (#5992)
  Honor mappingStatus when requesting to compute meshes ad-hoc (#5982)
  Add UI to globalize incomplete floodfill(s) (#5905)
  Add auto scaling for color layer (#5961)
  Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983)
  Fix dashboard refresh button behaviour (#5971)
  Update nanoid, trim-off-newlines and node-fetch (#5979)
  Add Arthur’s Alias in Build Notification Script (#5943)
  fix nml upload by providing process browser shim (#5987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Refresh" button not immediately usable
2 participants