Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI to globalize incomplete floodfill(s) #5905

Merged
merged 21 commits into from
Jan 26, 2022
Merged

Add UI to globalize incomplete floodfill(s) #5905

merged 21 commits into from
Jan 26, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Dec 13, 2021 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • set up wk worker locally (use the newest version and let me know in case you want to use docker; I had to do some adjustments to the setup which are not yet on the worker's master)
  • open a volume annotation (ideally with a fallback segmentation layer)
  • brush something (A)
  • initiate a floodfill on a rather large segment (B)
  • a bounding box should be added to the bbox tab
  • use the new globalize-button. see screenshot:
    image
  • a modal should open where you can specify a new DS name:
    image
  • when the job has completed, a new DS should appear in the dashboard which should have a segmentation layer with:
    • brush (A) should be included
    • the floodfill from (B) should be completed

Before globalize:
before-globalize

After globalize:
after-globalize

Issues:

(Please delete unneded items, merge only when none are left open)

@philippotto philippotto self-assigned this Dec 13, 2021
philippotto
philippotto commented Dec 13, 2021
View reviewed changes
conf/application.conf Outdated Show resolved Hide resolved
@philippotto philippotto changed the title [WIP] Globalize floodfill Add UI to globalize incomplete floodfill(s) Jan 21, 2022
daniel-wer
daniel-wer reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, and thanks for the screenshots and testing instructions! 🙏

I'll try to setup a worker locally and will report back after testing.

frontend/javascripts/oxalis/view/components/categorization_label.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/bounding_box_tab.js Show resolved Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/bounding_box_tab.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/bounding_box_tab.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/bounding_box_tab.js Outdated Show resolved Hide resolved
@daniel-wer
Copy link
Member

Worked really well for me 👍
The floodfill seems to take a long time but that's not related to this PR and I know that you've already spent time investigating and improving this, so there's likely no easy wins left, there.

philippotto
philippotto commented Jan 26, 2022
View reviewed changes
Copy link
Member Author

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your feedback! I think, I incorporated everything :)

frontend/javascripts/oxalis/view/components/categorization_label.js Outdated Show resolved Hide resolved
daniel-wer
daniel-wer approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM 👍

@philippotto philippotto enabled auto-merge (squash) January 26, 2022 13:26
@philippotto philippotto merged commit ef9c1fa into master Jan 26, 2022
@philippotto philippotto deleted the globalize-floodfill branch January 26, 2022 13:59
hotzenklotz added a commit that referenced this pull request Jan 27, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into docs
677baca 
* 'master' of github.com:scalableminds/webknossos:
  fix positioning of clip button (#5992)
  Honor mappingStatus when requesting to compute meshes ad-hoc (#5982)
  Add UI to globalize incomplete floodfill(s) (#5905)
  Add auto scaling for color layer (#5961)
  Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983)
  Fix dashboard refresh button behaviour (#5971)
  Update nanoid, trim-off-newlines and node-fetch (#5979)
  Add Arthur’s Alias in Build Notification Script (#5943)
  fix nml upload by providing process browser shim (#5987)
hotzenklotz added a commit that referenced this pull request Feb 3, 2022
@hotzenklotz
Merge branch 'delete_tree_shortcut' of github.com:scalableminds/webkn…
ed1cae1 
…ossos into delete_tree_shortcut

* 'delete_tree_shortcut' of github.com:scalableminds/webknossos:
  Add option to change active segement (#6006)
  ship expanded testdata (#6004)
  Allow Download of Public Annotations While Logged Out (#6001)
  Increase maximum bucket count limit for segmentation layers (#6000)
  Allow cancelling uploads (#5958)
  Store layer visibility with annotation (#5967)
  Fix async volume bugs (#5955)
  fix positioning of clip button (#5992)
  Honor mappingStatus when requesting to compute meshes ad-hoc (#5982)
  Add UI to globalize incomplete floodfill(s) (#5905)
  Add auto scaling for color layer (#5961)
  Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983)
  Fix dashboard refresh button behaviour (#5971)
  Update nanoid, trim-off-newlines and node-fetch (#5979)
  Add Arthur’s Alias in Build Notification Script (#5943)
  fix nml upload by providing process browser shim (#5987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippotto @daniel-wer @fm3