-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more guidelines for labelling code examples for Scala 2/3 #2768
Conversation
…to a Scala version
…ala in the “version-specific-notice”
…es, and adjust the “version-specific-notice”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You kept the "Scala 2 and 3" tab on ca-given-using-clauses.md
which is a bit strange.
or is this intentional because its "otherwise stated"?
I kept that one because it shows what the code looks like when we don’t use given/using. I also kept a similar code example with “Scala 2 and 3” in the Union Types page, which shows an alternative to union types. But I agree that in the given/using page I could remove the code tab, though, if you think it is confusing. |
Also, apply the recommended approach to a couple of existing pages.
Before: