Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add code tab in types-union.md #2754

Closed
wants to merge 3 commits into from
Closed

add code tab in types-union.md #2754

wants to merge 3 commits into from

Conversation

benluo
Copy link
Contributor

@benluo benluo commented Mar 21, 2023

No description provided.

julienrf
julienrf requested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benluo, however since the file describes a feature that has no equivalent in Scala 2 we follow a different style, see my comment below.

_overviews/scala3-book/types-union.md Show resolved Hide resolved
@julienrf julienrf mentioned this pull request Mar 31, 2023
Open
@julienrf julienrf mentioned this pull request Apr 12, 2023
Closed
@julienrf
Copy link
Contributor

Hey @benluo,
We have decided to streamline the way we “label” pages of documentation that are specific to a Scala version by using metadata in the YAML front matter instead of tabs around the code examples. Please see the PR #2768 for more details. I also went ahead and migrated the file types-union.md in that PR.
Thank you again for all your contributions!

@julienrf julienrf closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benluo @julienrf