Add code tabs for _overviews/scala3-book/types-union.md #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Dec 9, 2022
| ### Alternative to Union Types | ||
| As shown, union types can be used to represent alternatives of several different types, without requiring those types to be part of a custom-crafted class hierarchy, or requiring explicit wrapping. | ||
|
|
||
| #### Pre-planning the Class Hierarchy | ||
| Other languages would require pre-planning of the class hierarchy, like the following example illustrates: | ||
|
|
||
| {% tabs union-preplanning %} | ||
|
|
||
| {% tab 'Scala 3 Only' %} |
There was a problem hiding this comment.
Suggested change
| {% tab 'Scala 3 Only' %} | |
| {% tab 'Scala 2 and 3' %} |
bishabosha
reviewed
Dec 9, 2022
| {% endtab %} | ||
|
|
||
| {% endtabs %} | ||
|
|
||
| ### Alternative to Union Types | ||
| As shown, union types can be used to represent alternatives of several different types, without requiring those types to be part of a custom-crafted class hierarchy, or requiring explicit wrapping. | ||
|
|
||
| #### Pre-planning the Class Hierarchy | ||
| Other languages would require pre-planning of the class hierarchy, like the following example illustrates: |
There was a problem hiding this comment.
Suggested change
| Other languages would require pre-planning of the class hierarchy, like the following example illustrates: | |
| In other languages, such as Scala 2, you would require pre-planning of the class hierarchy, like the following example illustrates: |
bishabosha
requested changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #2481
made on Warsaw Scala Spree