feat: support sa11y on node 18 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work: @W-13158122
Work: @W-13158122
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 23 23
Lines 373 373
Branches 71 71
=======================================
Hits 365 365
Misses 8 8 |
navateja-alagam
commented
Jun 5, 2023
| @@ -40,7 +42,7 @@ | |||
| "release:version:auto": "yarn release:version --conventional-commits --no-changelog && yarn build:clean", | |||
| "release:publish": "yarn test:clean && lerna publish from-package", | |||
| "test": "jest --coverage --runInBand", | |||
| "test:ci": "yarn lint:all && yarn test --ci --reporters=default --reporters=jest-junit && yarn test:wdio", | |||
| "test:ci": "yarn lint:all:except:depgraph && yarn test --ci --reporters=default --reporters=jest-junit && yarn test:wdio", | |||
There was a problem hiding this comment.
'package-dependency-graph' has an issue generating dep graph on Node 18. Entered an issue item on the package.
For now, bypassing the dep graph generation check as part of CI processes, will see for a fix from package owners or look for an alternative as how it goes. W-13534678 to track.
jasonschroeder-sfdc
approved these changes
Jun 5, 2023
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.