Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sa11y on node 18 #475

Merged
merged 3 commits into from
Jun 5, 2023
+14 −11
Merged

feat: support sa11y on node 18 #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
156f4de
feat: support sa11y on node 18
navateja-alagam Jun 5, 2023
6dcf113
feat: dont run depgraph in ci, release, push processes
navateja-alagam Jun 5, 2023
bff9237
Merge branch 'master' into sa11y-node-18
navateja-alagam Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
matrix:
node-version:
- 16.x
- 18.x
os:
- ubuntu-latest

Expand Down
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
"build:ci": "yarn install --frozen-lockfile && yarn build",
"build:clean": "tsc --build --clean && rimraf packages/**/dist && yarn build:ci",
"build:watch": "tsc --build --watch",
"clean": "lerna exec rimraf node_modules/ dist/ tsconfig.tsbuildinfo && rimraf node_modules",
"commit": "! git diff --cached --exit-code && lint-staged && git-cz",
"install:clean": "lerna clean --yes && rimraf yarn.lock && rimraf node_modules && yarn install",
"install:update": "yarn audit; yarn upgrade-interactive --latest && yarn install:clean && yarn test:clean",
"lint": "eslint . --ext ts,js,md",
"lint:all": "tsc --noEmit && yarn lint && yarn lint:lockfile && yarn lint:deps && yarn lint:depgraph",
"lint:all:except:depgraph": "tsc --noEmit && yarn lint && yarn lint:lockfile && yarn lint:deps",
"lint:deps": "lerna exec depcheck",
"lint:depgraph": "yarn pkg:depgraph && git diff --quiet docs/sa11y_dependency_graph.svg || (echo 'Dependency graph needs to be updated!'; exit 1)",
"lint:fix": "yarn lint --fix",
Expand All @@ -40,7 +42,7 @@
"release:version:auto": "yarn release:version --conventional-commits --no-changelog && yarn build:clean",
"release:publish": "yarn test:clean && lerna publish from-package",
"test": "jest --coverage --runInBand",
"test:ci": "yarn lint:all && yarn test --ci --reporters=default --reporters=jest-junit && yarn test:wdio",
"test:ci": "yarn lint:all:except:depgraph && yarn test --ci --reporters=default --reporters=jest-junit && yarn test:wdio",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'package-dependency-graph' has an issue generating dep graph on Node 18. Entered an issue item on the package.

For now, bypassing the dep graph generation check as part of CI processes, will see for a fix from package owners or look for an alternative as how it goes. W-13534678 to track.

"test:clean": "yarn build:clean && yarn test:ci",
"test:debug": "SA11Y_DEBUG=1 node --inspect node_modules/.bin/jest --runInBand --watch",
"test:watch": "jest --watch",
Expand Down Expand Up @@ -109,6 +111,6 @@
"webdriverio": "7.31.1"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/assert/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/browser-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/format/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/jest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/preset-rules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/test-integration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"@sa11y/wdio": "4.0.0-alpha.0"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/test-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"@jest/globals": "28.1.3"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}
2 changes: 1 addition & 1 deletion packages/wdio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
"access": "public"
},
"engines": {
"node": "^16"
"node": "^16 || ^18"
}
}