Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add support for node@18 (current LTS) #376

Closed
pozil opened this issue Feb 13, 2023 · 4 comments · Fixed by #475
Closed

Feature request: add support for node@18 (current LTS) #376

pozil opened this issue Feb 13, 2023 · 4 comments · Fixed by #475

Comments

@pozil
Copy link

pozil commented Feb 13, 2023

Hi team, could you upgrade sa11y so that it supports the latest Node LTS version (v18)?

For reference, when installing a project that contains sa11y with node@18, you get these warnings:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/[email protected]',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v1[8](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:9).13.0', npm: '9.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/[email protected]',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '[9](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:10).3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/[email protected]',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '9.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa[11](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:12)y/[email protected]',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '9.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/[email protected]',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.[13](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:14).0', npm: '9.3.0' }
npm WARN EBADENGINE }

From my experience, sa11y works just fine despite the warnings.

@ClayChipps
Copy link

Echoing @pozil, it would be great if this could be updated. I am wanting to implement this into our tests, but my team is running node v18 and therefore we cannot even begin using the tool.

@tubone24
Copy link

tubone24 commented Apr 6, 2023

My team is also using Node v18.14.0, but only LWC has to use Node v16.19.0, so I would be happy to see it upgraded.

However, I have confirmed that unit test works even with Node v18.14.0, although I get WARNING when I do npm install, so just updating the required node version may not be a problem.

@yippie
Copy link

yippie commented Apr 24, 2023

Given that Node 16 is EOL very soon, this is an absolute MUST

@navateja-alagam
Copy link
Collaborator

Hi folks, Sa11y has got the Node v18 compatibility now in v5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants