Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] "Add generated key as an owner" url doesn't work( wrong format) #3096

Closed
liliya-soroka opened this issue May 8, 2023 · 9 comments
Closed
Assignees
Labels
bug Doesn't work as expected Major Fix within 2 weeks

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented May 8, 2023

Bug description
"Add generated key as an owner" url doesn't work( wrong URL format)
Steps To Reproduce

  1. precondition: safe is added, no owner key on the mobile
  2. go to the "owner key" and generate key
  3. skip backup -> click "Share link"
  4. try to open the shared link on web or mobile( safe owner key should be added on mobile before the URL check)

Current result:
The add owner flow is not opened
Expected Result
Make sure that the link starts "add owner" key if the safe from the URL in "write" mode is opened

For reference please also check #2480 (comment)

RPReplay_Final1683553165.MP4

Example of the link - https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/addOwner%3Faddress=0xC92aCAd4c19dF40bB43E6c83Ba4b257C8F26A84b
Device & App version

  • Device/OS: iPhone 11/16.2
  • App version: 3.19.2(1730)

Environment
prod
Additional info
(Optional)

@liliya-soroka liliya-soroka added bug Doesn't work as expected Major Fix within 2 weeks labels May 8, 2023
@DmitryBespalov
Copy link
Contributor

@liliya-soroka @the-real-chrizzo the web app has removed route to the 'add owner' modal, so the previous links that were used are not supported anymore.

So, the uri with a pattern {web app}/{chain prefix}:{safe address}/addOwner?address={new owner address} is not supported in the web app.

Below is the current state of the web app when opening 'add owner' modal

There are several options:

@DmitryBespalov
Copy link
Contributor

Related: #3297

@DmitryBespalov DmitryBespalov removed the blocked Can't be worked on label Aug 16, 2023
DmitryBespalov added a commit that referenced this issue Aug 16, 2023
- Changed the link format
- Refactored the link generation
@DmitryBespalov
Copy link
Contributor

new pattern: {web app}/addOwner?safe={chain prefix}:{safe address}&address={new owner address}

@liliya-soroka
Copy link
Member Author

liliya-soroka commented Aug 30, 2023

@liliya-soroka
Copy link
Member Author

liliya-soroka commented Oct 5, 2023

@DmitryBespalov , when the owner connected , safe settings page on set up is opened without any information about the address I want to add as an owner

Image

app version 3.24.0(1967)

@DmitryBespalov
Copy link
Contributor

@liliya-soroka ok, the reason seems to be in this: #3337

@liliya-soroka
Copy link
Member Author

clear, the issue is closed.
The url on web opens nur settings/setup. Not implemented on the web UI the possibility to open Add owner tx flow and prefilled owner address

@DmitryBespalov
Copy link
Contributor

I'll turn it off because it takes more time than benefit

@liliya-soroka
Copy link
Member Author

Verified
app version 3.24.0(1969) - the screen was hidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as expected Major Fix within 2 weeks
Projects
None yet
Development

No branches or pull requests

2 participants