-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] "Add generated key as an owner" url doesn't work( wrong format) #3096
Comments
@liliya-soroka @the-real-chrizzo the web app has removed route to the 'add owner' modal, so the previous links that were used are not supported anymore. So, the uri with a pattern Below is the current state of the web app when opening 'add owner' modal There are several options:
|
Related: #3297 |
- Changed the link format - Refactored the link generation
new pattern: |
Reopened:
|
@DmitryBespalov , when the owner connected , safe settings page on set up is opened without any information about the address I want to add as an owner app version 3.24.0(1967) |
@liliya-soroka ok, the reason seems to be in this: #3337 |
clear, the issue is closed. |
I'll turn it off because it takes more time than benefit |
GH-3096 remove the addOwner functionality from the flow
Verified |
Bug description
"Add generated key as an owner" url doesn't work( wrong URL format)
Steps To Reproduce
Current result:
The add owner flow is not opened
Expected Result
Make sure that the link starts "add owner" key if the safe from the URL in "write" mode is opened
For reference please also check #2480 (comment)
RPReplay_Final1683553165.MP4
Example of the link - https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/addOwner%3Faddress=0xC92aCAd4c19dF40bB43E6c83Ba4b257C8F26A84b
Device & App version
Environment
prod
Additional info
(Optional)
The text was updated successfully, but these errors were encountered: