Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3096 addOwner link update #3299

Merged
merged 5 commits into from
Aug 21, 2023
Merged

GH-3096 addOwner link update #3299

merged 5 commits into from
Aug 21, 2023

Conversation

DmitryBespalov
Copy link
Contributor

@DmitryBespalov DmitryBespalov commented Aug 16, 2023

Handles #3096

Changes proposed in this pull request:

  • Changed the link format
  • Refactored the link generation
Screen.Recording.2023-08-21.at.10.59.53.mov

- Changed the link format
- Refactored the link generation
@DmitryBespalov DmitryBespalov requested review from MouazAlzahabi and removed request for MouazAlzahabi August 16, 2023 17:07
@DmitryBespalov DmitryBespalov self-assigned this Aug 16, 2023
@DmitryBespalov DmitryBespalov marked this pull request as draft August 16, 2023 17:08
@DmitryBespalov DmitryBespalov marked this pull request as ready for review August 21, 2023 08:16
@codecov-commenter
Copy link

Codecov Report

Merging #3299 (07936d3) into main (8197b41) will decrease coverage by 1.57%.
Report is 1778 commits behind head on main.
The diff coverage is 0.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##            main   #3299      +/-   ##
========================================
- Coverage   8.75%   7.18%   -1.57%     
========================================
  Files        620     767     +147     
  Lines      31233   41580   +10347     
========================================
+ Hits        2733    2986     +253     
- Misses     28500   38594   +10094     
Files Changed Coverage Δ
Multisig/App/AppDelegate+Messaging.swift 0.00% <0.00%> (ø)
Multisig/App/AppDelegate.swift 0.00% <0.00%> (ø)
Multisig/App/SceneDelegate.swift 0.00% <0.00%> (-52.71%) ⬇️
Multisig/App/RemoteNotificationHandler.swift 7.90% <1.66%> (-11.66%) ⬇️

... and 447 files with indirect coverage changes

@MouazAlzahabi
Copy link
Contributor

@DmitryBespalov I just noticed that you add the password checker dependency, is it intended to do that here instead of the ticket related pr?

@DmitryBespalov
Copy link
Contributor Author

@MouazAlzahabi oh this was a leftover from the research task. Should not be here.

@DmitryBespalov DmitryBespalov merged commit 08b3b72 into main Aug 21, 2023
@DmitryBespalov DmitryBespalov deleted the GH-3096/add-owner-link branch August 21, 2023 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants