[iOS] [universal link]It should be possible to open staging and product urls in the proper app #2480

liliya-soroka · 2022-07-13T15:29:16Z

Bug description
[universal link]It should be possible to open staging and product urls in the proper app
Steps To Reproduce

Open links from staging on mobile
https://safe-team.staging.gnosisdev.com/rin:0x1230B3d59858296A31053C1b8562Ecf89A2f888b/transactions/ethereum_0x1230B3d59858296A31053C1b8562Ecf89A2f888b_0xb646fd83d156a4da55f38e6668ce95ebdb13a6e35057286b7afb6bf021b8c4a1_0x1674b3fd93555c44

https://safe-team.staging.gnosisdev.com/app/matic:0xb412684F4F0B5d27cC4A4D287F42595aB3ae124D/balances
https://safe-team.staging.gnosisdev.com/app/matic:0x7824DFC748f9048174863173f0504491CE58ba2D/balances
https://safe-team.staging.gnosisdev.com/app/matic:0x7824DFC748f9048174863173f0504491CE58ba2D/transactions/history
https://safe-team.staging.gnosisdev.com/app/matic:0x7824DFC748f9048174863173f0504491CE58ba2D/transactions/queue

Expected Result

Screenshots

Also to retest:

Adding owner from link
Sharing add owner link

What needs to be done
(From refinement on February 14th)

Investigation what needs to be done on mobile side and fix if it's mobile only
Timbox 4 pomodoros

Device & App version

Device/OS: iPhone 11/15.4
App version: 3.14.0 (1204)

Environment
staging
Additional info
(Optional)

…om_config gh-2480 Use web app link from config

JagoFigueroa · 2022-07-20T09:58:22Z

Hola guys! Unfortunately none of the links shared on this ticket are opening for me on the staging version of the app ( I'm at version 3.14.0 (1213).

If I open the link from a note it will open the browser for me with no option to open the app from there and if I paste the link on the browser directly I will see no option to open the link on the app as well.

Could you have a look? Thanks!

DmitryBespalov · 2022-07-20T09:59:20Z

we'll do, but this would be not a blocker for a release. The production needs to open, that's important

biafra23 · 2022-09-09T12:56:22Z

Has this been solved by the branch that has been merged?

biafra23 · 2023-03-01T16:23:41Z

According to https://developer.apple.com/documentation/Xcode/supporting-associated-domains#Add-the-associated-domain-file-to-your-website a file called .well-known/apple-app-site-association at that domain is needed.

https://gnosis-safe.io/.well-known/apple-app-site-association contains the follwing:

{
    "applinks": {
        "details": [
            {
                "appIDs": [
                    "ZKG876RKJ8.io.gnosis.multisig.prod.mainnet",
                    "ZKG876RKJ8.io.gnosis.multisig.prerelease",
                    "ZKG876RKJ8.io.gnosis.multisig.dev.mainnet",
                    "ZKG876RKJ8.io.gnosis.multisig.dev.rinkeby",
                    "ZKG876RKJ8.io.gnosis.multisig.staging.mainnet",
                    "ZKG876RKJ8.io.gnosis.multisig.staging.rinkeby"
                ],
                "components": [
                    {
                        "/": "*",
                        "comment": "Matches all universal links"
                    }
                ]
            }
        ]
    }
}

Our Gnosis team id was and is ZKG876RKJ8. So these appIDs should match.

biafra23 · 2023-03-02T08:37:05Z

To fix this we should do the following:

Find out what the current staging domain is -> https://safe-web-core.staging.5afe.dev/ ?
Put a similar file there WITHOUT the prod appIDs
Change the domain in the DEV entitlements file
Wait 24h until Apple caches the file in its CDN. Try ?mode=developer in the meantime.

biafra23 · 2023-03-02T11:22:21Z

We need the following to served at: https://safe-web-core.staging.5afe.dev/.well-known/apple-app-site-association

{
    "applinks": {
        "details": [
            {
                "appIDs": [
                    "ZKG876RKJ8.io.gnosis.multisig.prerelease",
                    "ZKG876RKJ8.io.gnosis.multisig.dev.mainnet",
                    "ZKG876RKJ8.io.gnosis.multisig.dev.rinkeby",
                    "ZKG876RKJ8.io.gnosis.multisig.staging.mainnet",
                    "ZKG876RKJ8.io.gnosis.multisig.staging.rinkeby"
                ],
                "components": [
                    {
                        "/": "*",
                        "comment": "Matches all universal links"
                    }
                ]
            }
        ]
    }
}

And at: https://app.safe.global/.well-known/apple-app-site-association we need:

{
    "applinks": {
        "details": [
            {
                "appIDs": [
                    "ZKG876RKJ8.io.gnosis.multisig.prod.mainnet"
                ],
                "components": [
                    {
                        "/": "*",
                        "comment": "Matches all universal links"
                    }
                ]
            }
        ]
    }
}

biafra23 · 2023-03-22T11:56:01Z

The fix will make sure, that URLs to tx details generated by the webapp will open the correct ios app (staging or prod). Regarding the wallet connect links, we will not be able to correctly open the staging app. The reason is that these urls are determined by the Dapp and not the bundli of the isntalled ios app.

liliya-soroka · 2023-03-31T17:32:18Z

staging URL is opened correctly - app version 3.19.0 (1654)
prod URL opens the correct app , but the tx details is not opened ( note the safe exists in the prod app) - the URL that was used - https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/transactions/tx?id=multisig_0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c_0x41eb3ed93edb66d77c9445419108f4893335d90ff43d1dc6fbf719e142121be6. - app version 3.19.0 (1658)

biafra23 · 2023-04-14T23:03:13Z

Apparently web and mobile create different urls:

Mobile created:
https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/transactions/multisig_0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c_0x41eb3ed93edb66d77c9445419108f4893335d90ff43d1dc6fbf719e142121be6

Web created:
https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/transactions/tx?id=multisig_0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c_0x41eb3ed93edb66d77c9445419108f4893335d90ff43d1dc6fbf719e142121be6

The difference is the tx?id= before the tx

This seems to be the ticket for the mobile implementation: #2463
Requirements: https://docs.google.com/document/d/1aoW-HZDeQCRpMVMaHOUZQZyBNMWcqCo51IEkq3zEBlE/edit#heading=h.t0of4xmer2ue

The other link types work on mobile and web:

https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/balances
https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/transactions/queue
https://app.safe.global/gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c/transactions/history

Would be interesting if web produces this format as well.
There is a redirect when they are resolved.
For example:
balances becomes: https://app.safe.global/balances?safe=gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c

liliya-soroka · 2023-04-17T13:04:37Z

The mobile app should support a new format to open the links from the web. Will it be a part of this issue or will we have a separate issue to support a new format?
In the PR - safe-global/safe-wallet-monorepo#1870 - the support of the old format links from the mobile app is added on web, so it will be possible to open the old links from mobile on web
@the-real-chrizzo and @MouazAlzahabi

liliya-soroka added the bug label Jul 13, 2022

elgatovital self-assigned this Jul 14, 2022

MouazAlzahabi added the Major label Jul 14, 2022

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Use web app link from config

a9feb3f

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust share link url to use config value

a8f2029

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust patterns

620a038

elgatovital mentioned this issue Jul 14, 2022

gh-2480 Use web app link from config #2485

Merged

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Use configuration singleton instead of creating new object

0c0e608

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust favicon link

63308f8

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Add app-path to web app link value

c090c8a

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Use web app link from config

b76b708

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust share link url to use config value

68d5e19

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust patterns

0307a1f

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Use configuration singleton instead of creating new object

b4a79af

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust favicon link

166549d

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Add app-path to web app link value

e6a1b61

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Adjust tests

a759871

elgatovital added a commit that referenced this issue Jul 14, 2022

gh-2480 Remove empty lines

0812d86

MouazAlzahabi pushed a commit that referenced this issue Jul 14, 2022

Merge pull request #2485 from safe-global/gh-2480/use_web_app_link_fr…

2dfc85e

…om_config gh-2480 Use web app link from config

biafra23 assigned biafra23 and unassigned elgatovital Mar 2, 2023

biafra23 pushed a commit that referenced this issue Mar 13, 2023

gh-2480 Update applink entitlements

b3f2151

biafra23 mentioned this issue Mar 13, 2023

gh-2480 - Update applink entitlements #2956

Merged

biafra23 pushed a commit that referenced this issue Mar 13, 2023

gh-2480 Update applink entitlements (#2956)

9a4f5bc

biafra23 mentioned this issue Mar 13, 2023

apple-app-site-association file also needed in staging environment. safe-global/safe-wallet-monorepo#1766

Merged

3 tasks

the-real-chrizzo mentioned this issue Mar 14, 2023

[iOS] safe.global is opened instead of mobile app when wc in dapps is used #2951

Closed

biafra23 mentioned this issue Mar 20, 2023

GH-2951 Hostname necessary for STAGING #2972

Merged

katspaugh mentioned this issue Apr 15, 2023

Old transaction id links don't work safe-global/safe-wallet-monorepo#1869

Closed

the-real-chrizzo mentioned this issue May 9, 2023

[iOS] "Add generated key as an owner" url doesn't work( wrong format) #3096

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] [universal link]It should be possible to open staging and product urls in the proper app #2480

[iOS] [universal link]It should be possible to open staging and product urls in the proper app #2480

liliya-soroka commented Jul 13, 2022 •

edited by the-real-chrizzo

Loading

JagoFigueroa commented Jul 20, 2022

DmitryBespalov commented Jul 20, 2022

biafra23 commented Sep 9, 2022

biafra23 commented Mar 1, 2023 •

edited

Loading

biafra23 commented Mar 2, 2023 •

edited

Loading

biafra23 commented Mar 2, 2023 •

edited

Loading

biafra23 commented Mar 22, 2023

liliya-soroka commented Mar 31, 2023 •

edited

Loading

biafra23 commented Apr 14, 2023 •

edited

Loading

liliya-soroka commented Apr 17, 2023

[iOS] [universal link]It should be possible to open staging and product urls in the proper app #2480

[iOS] [universal link]It should be possible to open staging and product urls in the proper app #2480

Comments

liliya-soroka commented Jul 13, 2022 • edited by the-real-chrizzo Loading

JagoFigueroa commented Jul 20, 2022

DmitryBespalov commented Jul 20, 2022

biafra23 commented Sep 9, 2022

biafra23 commented Mar 1, 2023 • edited Loading

biafra23 commented Mar 2, 2023 • edited Loading

biafra23 commented Mar 2, 2023 • edited Loading

biafra23 commented Mar 22, 2023

liliya-soroka commented Mar 31, 2023 • edited Loading

biafra23 commented Apr 14, 2023 • edited Loading

liliya-soroka commented Apr 17, 2023

liliya-soroka commented Jul 13, 2022 •

edited by the-real-chrizzo

Loading

biafra23 commented Mar 1, 2023 •

edited

Loading

biafra23 commented Mar 2, 2023 •

edited

Loading

biafra23 commented Mar 2, 2023 •

edited

Loading

liliya-soroka commented Mar 31, 2023 •

edited

Loading

biafra23 commented Apr 14, 2023 •

edited

Loading