Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UniversalLinks] Support deep linking for missing routes #2463

Closed
2 of 4 tasks
MouazAlzahabi opened this issue Jul 2, 2022 · 2 comments
Closed
2 of 4 tasks

[UniversalLinks] Support deep linking for missing routes #2463

MouazAlzahabi opened this issue Jul 2, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@MouazAlzahabi
Copy link
Contributor

MouazAlzahabi commented Jul 2, 2022

Description

We want to support deep linking for the following screens

  • Assets balances
  • Transactions queue
  • Transactions history
  • Transaction details

What To Do

  1. Add new navigation methods to NavigationRoute
  2. Adjust method canNavigate in MainTabBarViewController.swift line 380 to handle the new added cases

Transaction details

https://gnosis-safe.io/app/{chain prefix}:{safe_address}/transactions/{client_gateway_transaction_id}

Asset Balances

https://gnosis-safe.io/app/{chain prefix}:{safe_address}/balances

Transaction Queue

https://gnosis-safe.io/app/{chain prefix}:{safe_address}/transactions/queue

Transaction History

https://gnosis-safe.io/app/{chain prefix}:{safe_address}/transactions/history

NOTE

For the staging environment, the app must support using the safe-team.staging.gnosisdev.com host instead of the gnosis-safe.io host.

Acceptance Criteria

  • We can open transaction mentioned screens by using shared link from web interface
  • If the safe is added to the app, and corresponding link is opened, the app opens at the intended screen
  • If the safe is not added to the app, then the link is ignored (nothing happens)

Links

@MouazAlzahabi MouazAlzahabi added enhancement New feature or request Question? Further information is requested labels Jul 2, 2022
@DmitryBespalov DmitryBespalov removed the Question? Further information is requested label Jul 5, 2022
@DmitryBespalov
Copy link
Contributor

@MouazAlzahabi I have updated the requirements with the link URL formats

@MouazAlzahabi MouazAlzahabi self-assigned this Jul 5, 2022
MouazAlzahabi pushed a commit that referenced this issue Jul 12, 2022
…g-for-missing-routes

Gh 2463/support deep linking for missing routes
@liliya-soroka
Copy link
Member

Verified
the issues for staging app and for incoming tx are reported separately

app version 3.14.0 (1204)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants