feat(wallet): revamped landing page #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Hero section * fix: lint * feat: add "Watch demo" play button * fix: control video play * feat: add a bottom gradient over the paused video * styles: fix border-radius on video * feat: temporarily use /wallet-new slug because page path conflct with the current version * feat: move section content back to the .json file * fix: restore CenteredTextBlock * Revert "fix: restore CenteredTextBlock" This reverts commit f6a463b.
Branch preview✅ Deployed successfully in branch deployment: |
* feat: Hero section * fix: lint * feat: add "Watch demo" play button * fix: control video play * feat: add a bottom gradient over the paused video * styles: fix border-radius on video * feat: temporarily use /wallet-new slug because page path conflct with the current version * feat: commonCMS/Marquee * feat: generic Card grid * feat: declare content in wallet.json * fix: undo unrelated change * fix: do not render the component without `items` * fix: remove conditional operator
* feat: Hero section * fix: lint * feat: add "Watch demo" play button * fix: control video play * feat: add a bottom gradient over the paused video * styles: fix border-radius on video * feat: temporarily use /wallet-new slug because page path conflct with the current version * feat: commonCMS/Marquee * feat: generic Card grid * feat: Vertical Slide * feat: display images when clicking the cards * fix: lint * fix: undo unrelated changes * feat: declare VerticalSlide content in wallet.json * styles: mobile styles * fix: extract expression to a variable
* feat: FeatureCards component * feat: ecosystem projects card * feat: rest of Featured cards * feat: cta to wallet app * Update src/components/Wallet/FeatureCards/index.tsx Co-authored-by: Aaron Cook <[email protected]> * Apply suggestions from code review Co-authored-by: Aaron Cook <[email protected]> --------- Co-authored-by: Aaron Cook <[email protected]>
* feat: common FAQ section * feat: import FAQ content from CMS * fix: undo unrelated changes
* v1.5.7 * feat: Wallet page Vertical stack * styles: apply styles * styles: adjust title wrapper width * Apply suggestions from code review Co-authored-by: Aaron Cook <[email protected]> --------- Co-authored-by: Aaron Cook <[email protected]>
* feat: "subscribe to latest" section * feat: display laptop image * fix: copy changes
* feat: scroll based animation * feat: scroll based animation in VerticalStack * fix: handle card click * fix: move sticky section to laptop view * fix: ignore TS line for testing
* styles: center play button * style: fix logos * style: address comments on sections margins * style: center Watch Demo button * fix: consistent CTA copy * style: increase card padding * fix: stretched images * fix: update starknet logo * feat: replace assets
* feat: sign up form * chore: add code to actions
iamacook
reviewed
Nov 22, 2024
Comment on lines
12
to
25
| const registerEmail = (email: string) => { | ||
| fetch(PUSHWOOSH_ENDPOINT, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: JSON.stringify({ | ||
| email, | ||
| application: process.env.NEXT_PUBLIC_PUSHWOOSH_WALLET_APPLICATION_CODE, | ||
| }), | ||
| }).catch((error) => { | ||
| console.error('Error:', error) | ||
| }) | ||
| } |
There was a problem hiding this comment.
This is very similar to the registerEmail function found in src/components/Rewards/SignUpForm/index.tsx. What do you think about refactoring it? Not sure if we want to log either, and whether we need handle any errors thrown (not forgetting !res.ok).
| label="Email:" | ||
| variant="outlined" | ||
| type="email" | ||
| name="email" |
There was a problem hiding this comment.
Suggested change
| name="email" | |
| name={FIELD_NAME} |
| const data = new FormData(e.target as HTMLFormElement) | ||
| const email = data.get(FIELD_NAME) | ||
|
|
||
| registerEmail(email as string) |
There was a problem hiding this comment.
Considering the usage, this should be awaited and setIsSubmitted called if no error occurs.
| <div className={layoutCss.centeredContent}> | ||
| <form onSubmit={handleSubmit} className={css.form}> | ||
| <TextField | ||
| id="outlined-basic" |
There was a problem hiding this comment.
Suggested change
| id="outlined-basic" |
|
|
||
| <div className={css.secondaryText}> | ||
| By signing up to the newsletter, I confirm that I read and agree to the{' '} | ||
| <Link href="https://safe.global/privacy" target="_blank" rel="noreferrer"> |
There was a problem hiding this comment.
Suggested change
| <Link href="https://safe.global/privacy" target="_blank" rel="noreferrer"> | |
| <Link href={AppRoutes.privacy} target="_blank" rel="noreferrer"> |
|
|
||
| const offset = indexToScrollProgress(index) * sectionHeight | ||
|
|
||
| // @ts-ignore |
There was a problem hiding this comment.
The current version of TypeScript is missing this type value. I left a better comment and replaced the // @ts-ignore by // @ts-expect-error
src/config/constants.ts
Outdated
| @@ -45,3 +45,5 @@ export const ECOSYSTEM_DATA_URL = IS_PRODUCTION | |||
| : 'https://ecosystem-database.staging.5afe.dev' | |||
|
|
|||
| export const COMMS_EMAIL = '[email protected]' | |||
|
|
|||
| export const PUSHWOOSH_ENDPOINT = 'https://api.pushwoosh.com/json/1.3/registerEmail' | |||
There was a problem hiding this comment.
Nit: maybe we should name this a bit more declaratively, e.g. PUSHWOOSH_REGISTRATION_ENDPOINT
iamacook
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements new Wallet page design
Figma
https://www.figma.com/design/qtXXlwdslAze6yNbLLzIRa/Website-redesign-2.0?node-id=15367-15363&node-type=frame&t=horanWl7oRJbI5Vk-0