feat(Wallet): Big cards grid #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the current version
DiogoSoaress
changed the base branch from
wallet-landing-page
to
wallet-networks-slider
Branch preview✅ Deployed successfully in branch deployment: |
DiogoSoaress
changed the base branch from
wallet-networks-slider
to
wallet-landing-page
DiogoSoaress
changed the base branch from
wallet-landing-page
to
wallet-networks-slider
DiogoSoaress
changed the base branch from
wallet-networks-slider
to
wallet-landing-page
DiogoSoaress
force-pushed
the
wallet-big-cards
branch
from
9866499
to
4947625
Compare
iamacook
reviewed
Oct 29, 2024
| const BigCardsGrid = ({ items }: { items: Array<BaseBlock['items'] & { component: string }> }) => ( | ||
| <Container className={layoutCss.containerShort}> | ||
| <Grid container spacing={{ xs: '30px', xl: '50px' }}> | ||
| {items?.map((item, index) => { |
There was a problem hiding this comment.
If there are no items, this will still render the Container. Is this expected?
There was a problem hiding this comment.
The content is static so I think this can't really become an issue but I made it render conditionally nevertheless. Thanks for the catch.
| {items?.map((item, index) => { | ||
| const { component } = item | ||
|
|
||
| const CardComponent = getComponentByName(`${component}`, () => <></>) |
There was a problem hiding this comment.
Do we want to fallback to an "empty" component?
Suggested change
| const CardComponent = getComponentByName(`${component}`, () => <></>) | |
| const CardComponent = getComponentByName(component, () => <></>) |
There was a problem hiding this comment.
I think it's a suitable fallback. Do you have any other suggestion?
There was a problem hiding this comment.
I'm not sure - I'll leave it up to you.
iamacook
approved these changes
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements the Big Cards grid section of the Wallet landing page
Figma
https://www.figma.com/design/qtXXlwdslAze6yNbLLzIRa/Website-redesign-2.0?node-id=15367-15363&t=UyEbY16dBeLFg4eE-0
Obs: please disregard the commit history if possible. The PR has been open for a while and it was branched of a WIP branch