feat(wallet): centered text blocks #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deployed successfully in branch deployment: https://wallet_centered_text_block--homepage.review.5afe.dev |
DiogoSoaress
commented
Nov 6, 2024
| "buttons": [ | ||
| { | ||
| "text": "Subscribe", | ||
| "href": "https://safe.global", |
There was a problem hiding this comment.
Waiting for Danilo to provide the real link
DiogoSoaress
commented
Nov 6, 2024
| }, | ||
| { | ||
| "text": "View demo", | ||
| "href": "https://safe.global", |
There was a problem hiding this comment.
Waiting for the real URL
iamacook
reviewed
Nov 6, 2024
|
|
||
| const ImageGradient = ({ image }: Partial<BaseBlock>) => ( | ||
| <Container className={css.container}> | ||
| <img src={image?.src} alt={image?.alt} /> |
There was a problem hiding this comment.
If there's no image, should this be rendered? Might make sense to return null instead.
There was a problem hiding this comment.
I added an early return if the component doesn't receive image
src/content/wallet.json
Outdated
| { | ||
| "component": "commonCMS/Faq" | ||
| }, | ||
| { | ||
| "title": "Create your <b>smart account</b> now", |
There was a problem hiding this comment.
Suggested change
| "title": "Create your <b>smart account</b> now", | |
| "title": "Create your <b>Smart Account</b> now", |
src/content/wallet.json
Outdated
| "text": "Still have questions and want to know more about Safe {Wallet}? Watch our demo.", | ||
| "buttons": [ | ||
| { | ||
| "text": "Launch wallet", |
There was a problem hiding this comment.
Suggested change
| "text": "Launch wallet", | |
| "text": "Launch Safe{Wallet}", |
iamacook
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements the centered text blocks
Figma
https://www.figma.com/design/qtXXlwdslAze6yNbLLzIRa/Website-redesign-2.0?node-id=15367-15363&node-type=frame&t=11ZCWH0Op36rSecb-0