Update transitive dependency to work towards removing syn <1.0 dep #71919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Were you intending to land this and then follow up once those upstream PRs are merged and released, or do you want to wait here? If you're happy to merge now then I'm fine with that, r=me |
Mark-Simulacrum
added
S-waiting-on-author
|
I'm fine either way but since this prunes 2 dependencies already (hashbrown 0.5.0 and synstructure 0.12.1), let's land this now and I'll follow up when the upstream fixes are released. Thanks for taking a look! @bors r=Mark-Simulacrum |
|
📌 Commit 371ddd7 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
|
This PR failed in #72073 (comment) (re-rollup without this worked). Likely the lockfile needs updating. @bors r- |
bors
added
S-waiting-on-author
|
📌 Commit e26f35d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e26f35d with merge fbdc1a61e7aeb2779fe99f65841955f4c3ffc875... |
|
💔 Test failed - checks-azure |
bors
removed
the
S-waiting-on-bors
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 14, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 15, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
|
@bors p=1 |
|
⌛ Testing commit e26f35d with merge c4d9e53e27488374be218e4b96302b10acb2b5c2... |
|
@bors retry yield |
|
⌛ Testing commit e26f35d with merge 8fd1450a80cb804c450c1ba53dba0b18eb6a71f8... |
|
@bors retry yield |
|
⌛ Testing commit e26f35d with merge 70e1c77063eac6ece06b9b578733c055e118cd0c... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
@bors r+ rollup |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit e26f35d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#71625 (Improve the documentation for ManuallyDrop to resolve conflicting usage of terminology) - rust-lang#71919 (Update transitive dependency to work towards removing syn <1.0 dep) - rust-lang#72166 (Simpler slice `Iterator` methods) - rust-lang#72216 (Remove `lang_items\(\).*\.unwrap\(\)`) - rust-lang#72230 (Updated documentation of Prefix::VerbatimDisk) - rust-lang#72234 (Implement Default for proc_macro::TokenStream) - rust-lang#72258 (Fix typo Arbintrary to Arbitrary) Failed merges: r? @ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 27, 2020
Update transitive dependencies to remove some deps Similar to rust-lang#71919, this removes some (duplicate) dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210.
While working on #71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.