-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CDN for ci-caches on download #72027
Conversation
This will reduce costs, as well as lays the groundwork for developers to be able to locally pull the published docker images without needing AWS credentials.
I also set the CACHE_DOMAIN variable in azure's public and private libraries; didn't touch GHA at all. I wanted to also add support for pulling from this cache locally (e.g. when you want to test why android isn't working and don't want to wait for the docker build) but our cache keying appears to use absolute paths today which discouraged me from doing anything there -- seems hard to make that work well. Maybe we can explore relative paths there, but then there's also docker version and such to consider and altogether it seems like the wrong approach. |
@Mark-Simulacrum can you set the variable in the rust/src/ci/github-actions/ci.yml Lines 37 to 53 in 3fe4dd2
|
Set the variable and ran expansion. |
@bors r+ |
📌 Commit 9a4e718 has been approved by |
@bors r+ rollup |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 9a4e718 has been approved by |
…albini Use CDN for ci-caches on download This will reduce costs, as well as lays the groundwork for developers to be able to locally pull the published docker images without needing AWS credentials. r? @pietroalbini
Rollup of 10 pull requests Successful merges: - rust-lang#72014 (Deprecated emoji) - rust-lang#72019 (Fix debug assertion in error code) - rust-lang#72027 (Use CDN for ci-caches on download) - rust-lang#72044 (use min_specialization for some rustc crates where it requires no changes) - rust-lang#72052 (display `ConstKind::Param`) - rust-lang#72067 (Emit a warning when optimization fuel runs out) - rust-lang#72072 (doc: minus (U+2212) instead of dash (U+002D) for negative infinity) - rust-lang#72077 (Improve E0571 wording) - rust-lang#72107 (Clean up E0579 explanation) - rust-lang#72109 (Fix clippy warnings) Failed merges: r? @ghost
This will reduce costs, as well as lays the groundwork for developers to be able
to locally pull the published docker images without needing AWS credentials.
r? @pietroalbini