-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #72073
Rollup of 5 pull requests #72073
Conversation
Pulls in updated MSVC detection logic landed in rust-lang/cc-rs#488
Rework MIR drop tree lowering This PR changes how drops are generated in MIR construction. This is the first half of the fix for rust-lang#47949. Rather than generating the drops for a given unwind/break/continue/return/generator drop path as soon as they are needed, the required drops are recorded and get generated later. The motivation for this is * It simplifies the caching scheme, because it's now possible to walk up the currently scheduled drop tree to recover state. * The basic block order for MIR more closely resembles execution order. This PR also: * Highlights cleanup blocks in the graphviz MIR output. * Removes some unnecessary drop flag assignments.
…lacrum Update the `cc` crate Pulls in updated MSVC detection logic landed in rust-lang/cc-rs#488
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
…-types-section, r=kinnison,ollie27 Sort "implementations on foreign types" section in the sidebar Fixes rust-lang#71926. We were sorting by the ID instead of sorting by the name. They're not in the same order as the implementations but I think it makes more sense this way considering this is what we do for the methods as well. r? @kinnison cc @rust-lang/rustdoc
…lan-DPC Add missing backtick in E0569 explanation r? @Dylan-DPC
@bors r+ rollup=never p=5 |
📌 Commit 0a646ef has been approved by |
@rustbot modify labels: +rollup |
That's a weird GHA failure:
Cc @rust-lang/infra EDIT: Oh, same on Azure...? |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Maybe that's a weird way to tell me the lockfile is outdated? I'll recreate with fewer PRs. (EDIT: that's #72074) |
@bors r- |
It used to be the case that when the lockfile is outdated the cargo error clearly said that: something about "working with |
Successful merges:
cc
crate #71882 (Update thecc
crate)Failed merges:
r? @ghost