Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error E0365 to new format #35670

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Update error E0365 to new format #35670

merged 1 commit into from
Aug 17, 2016

Conversation

Xinayder
Copy link
Contributor

Fixes #35633 as part of #35233.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Thanks for the PR!

Looks good so far. The next step you'll need to do is to run this through tidy and fix any warnings tidy gives you.

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

@sophiajt
Copy link
Contributor

Actually, this looks like it might be clean. Let's give it a try.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 14, 2016

📌 Commit a026e2c has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 15, 2016
Rollup merge of rust-lang#35670 - RockyTV:e0365, r=jonathandturner
cf2a53a 
Update error E0365 to new format

Fixes rust-lang#35633 as part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 15, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Rollup merge of rust-lang#35670 - RockyTV:e0365, r=jonathandturner
5b6e6dc 
Update error E0365 to new format

Fixes rust-lang#35633 as part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 17, 2016
Closed
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of #35743 - jonathandturner:rollup, r=jonathandturner
b28ffa5 
Rollup of 24 pull requests

- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35691, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Rollup merge of rust-lang#35670 - RockyTV:e0365, r=jonathandturner
02a8e2c 
Update error E0365 to new format

Fixes rust-lang#35633 as part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 17, 2016
Merged
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of #35747 - jonathandturner:rollup, r=jonathandturner
7ac11ca 
Rollup of 23 pull requests

- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
@bors bors merged commit a026e2c into rust-lang:master Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xinayder @rust-highfive @sophiajt @bors