Rollup of 23 pull requests #35747
Merged
Rollup of 23 pull requests #35747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain why Rust does not implement traits for large arrays. Explain why most methods are implemented on slices rather than arrays.
The spacing seems inconsistent with existing style conventions.
Some people cite this list as "zomg Rust has so many keywords," so make it clear that these aren't all used by the language today.
I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.
Display all the remaining items of the iterator, similar to the `Debug` implementation for `core::slice::Iter`: https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937 Using the `as_slice` method that was added in: rust-lang#35447
…=Manishearth A disclaimer about keywords. Some people cite this list as "zomg Rust has so many keywords," so make it clear that these aren't all used by the language today.
…andturner Update compiler error 0030 to use new error format. Part of rust-lang#35233, Addresses rust-lang#35204 r? @jonathandturner
added 9 commits
August 17, 2016 06:25
…ed, r=steveklabnik expound on limitations of Rust's trait-based operator overloading Part of rust-lang#29330
…tln, r=GuillaumeGomez accumulate into vector and assert, instead of printing I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.
…xcrichton Implement `Debug` for `std::vec::IntoIter`. Display all the remaining items of the iterator, similar to the `Debug` implementation for `core::slice::Iter`: https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937 Using the `as_slice` method that was added in: rust-lang#35447
…sakis RUST_NEW_ERROR_FORMAT is no more So stop setting the environment variable.
Use UI test to test spans, instead of forced line break There must be lots more, but these are what I could easily find.
…andturner Updated E0394 & E0422 to new format Fixes rust-lang#35692 and rust-lang#35700, as part of rust-lang#35233. r? @jonathandturner
Bump version to 1.13
update E0409 to new error format fixes rust-lang#35699 as part of rust-lang#35233. r? @jonathandturner
Update E0005 to use a label Fixes rust-lang#35192 as Part of rust-lang#35233 r? @jonathandturner
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ r=10 |
|
📌 Commit c216617 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit c216617 has been approved by |
|
@bors p=10 |
|
@bors r=jonathandturner |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit c216617 has been approved by |
This was referenced Aug 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::ffi::CString::from_vec_unchecked. #35621, Update E0207 label to report parameter type #35660, ImproveNo stdliband related Documentation #35663, Update error E0365 to new format #35670, Update E0392 to new error format #35671, Update E0322 to new format #35672, Fix spacing in code of closures.md #35681, update E0375 to new format #35686, expound on limitations of Rust's trait-based operator overloading #35690, accumulate into vector and assert, instead of printing #35695, ImplementDebugforstd::vec::IntoIter. #35707, RUST_NEW_ERROR_FORMAT is no more #35708, Use UI test to test spans, instead of forced line break #35713, Updated E0394 & E0422 to new format #35722, Bump version to 1.13 #35725, update E0409 to new error format #35726, Update E0005 to use a label #35731