Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 24 pull requests #35743

Closed
wants to merge 53 commits into from
Closed

Rollup of 24 pull requests #35743

wants to merge 53 commits into from

Conversation

urschrei and others added 30 commits August 11, 2016 20:05
Explain why Rust does not implement traits for large arrays.

Explain why most methods are implemented on slices rather than arrays.
The spacing seems inconsistent with existing style conventions.
Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
Instead of listing every field it will now show missing `a`, `z`, `b`, and 1 other field
I'm only making this change in one place so that people can express
their preferences for this stylistic change. If/when this change is
approved I'll go ahead and translate the rest of the `std::ops`
examples.
Display all the remaining items of the iterator, similar to the `Debug`
implementation for `core::slice::Iter`:

https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937

Using the `as_slice` method that was added in:

rust-lang#35447
…=Manishearth

A disclaimer about keywords.

Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
Jonathan Turner added 19 commits August 16, 2016 22:19
…=nikomatsakis

run rustfmt on libsyntax_ext folder
…schkaj

Add doc example for `std::ffi::CString::from_vec_unchecked`.

None
Update E0207 label to report parameter type

Fixes rust-lang#35642.

r? @jonathandturner (Is this okay? I tagged you since it's a simple error fix similar to the other update ones.)
Improve `No stdlib` and related Documentation

This renames all lang item function names to the ones used in `libstd` and `libpanic_unwind`. It also explains the `eh_unwind_resume` lang item in the `libcore` documentation, where it was missing. A third function is also needed on certain compilation targets, so this was also added to the `No stdlib` documentation.
Fix spacing in code of closures.md

The spacing seems inconsistent with existing style conventions.
…ed, r=steveklabnik

expound on limitations of Rust's trait-based operator overloading

Part of rust-lang#29330
…dturner

Update the wording for E0063. This will truncate the fields to 3.

Instead of listing every field it will now show missing `a`, `z`, `b`, and 1 other field
This is for rust-lang#35218 as part of rust-lang#35233

r? @jonathandturner
…tln, r=GuillaumeGomez

accumulate into vector and assert, instead of printing

I'm only making this change in one place so that people can express
their preferences for this stylistic change. If/when this change is
approved I'll go ahead and translate the rest of the `std::ops`
examples.
…xcrichton

Implement `Debug` for `std::vec::IntoIter`.

Display all the remaining items of the iterator, similar to the `Debug`
implementation for `core::slice::Iter`:

https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937

Using the `as_slice` method that was added in:

rust-lang#35447
…sakis

RUST_NEW_ERROR_FORMAT is no more

So stop setting the environment variable.
Use UI test to test spans, instead of forced line break

There must be lots more, but these are what I could easily find.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@sophiajt
Copy link
Contributor Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Aug 17, 2016

📌 Commit 11be7c0 has been approved by jonathandturner

@TimNN
Copy link
Contributor

TimNN commented Aug 17, 2016

#35691 has a legit travis failure, failing this pr (in a local build) as well.

@bors
Copy link
Contributor

bors commented Aug 17, 2016

⌛ Testing commit 11be7c0 with merge b28ffa5...

bors added a commit that referenced this pull request Aug 17, 2016
@bors
Copy link
Contributor

bors commented Aug 17, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@sophiajt sophiajt closed this Aug 17, 2016
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.