std: Deprecate std::old_io::fs #22873

alexcrichton · 2015-02-27T21:34:23Z

This commit deprecates the majority of std::old_io::fs in favor of std::fs and
its new functionality. Some functions remain non-deprecated but are now behind a
feature gate called old_fs. These functions will be deprecated once
suitable replacements have been implemented.

The compiler has been migrated to new std::fs and std::path APIs where
appropriate as part of this change.

[breaking-change]

rust-highfive · 2015-02-27T21:34:36Z

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

huonw · 2015-02-28T00:37:03Z

Travis is failing.

alexcrichton · 2015-02-28T02:25:32Z

Ah oops, should be taken care of now

bors · 2015-02-28T16:21:11Z

☔ The latest upstream changes (presumably #22895) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2015-03-01T16:53:52Z

☔ The latest upstream changes (presumably #22880) made this pull request unmergeable. Please resolve the merge conflicts.

aturon · 2015-03-02T18:28:13Z

mk/docs.mk

@@ -273,11 +273,13 @@ compiler-docs: $(COMPILER_DOC_TARGETS)
 trpl: doc/book/index.html

 doc/book/index.html: $(RUSTBOOK_EXE) $(wildcard $(S)/src/doc/trpl/*.md) | doc/
+	@$(call E, rustbook: $@)


Is this intended? Seems unrelated to the goal of the PR...

Ah yes I figured I'd just clean up the output here to be a little more consistent with the rest of the build (now that it doesn't print the chapters to stdout by default)

aturon · 2015-03-02T18:36:42Z

LGTM

alexcrichton · 2015-03-02T18:39:10Z

@bors: r+ b10b656c8a802cd6260ddacb0edfb1dfc9bdbc1b p=1

alexcrichton · 2015-03-02T18:39:17Z

@bors: r=aturon b10b656c8a802cd6260ddacb0edfb1dfc9bdbc1b

bors · 2015-03-02T22:53:14Z

⌛ Testing commit b10b656 with merge 25ad046...

bors · 2015-03-02T23:18:35Z

💔 Test failed - auto-win-32-nopt-t

alexcrichton · 2015-03-02T23:29:22Z

@bors: r=aturon b30b276

bors · 2015-03-03T01:41:16Z

⌛ Testing commit b30b276 with merge a8aa138...

bors · 2015-03-04T08:22:00Z

⌛ Testing commit 0daf8ca with merge b3b8ce3...

bors · 2015-03-04T09:46:28Z

💔 Test failed - auto-mac-32-opt

Manishearth · 2015-03-04T10:00:14Z

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:237:42: 237:54 error: mismatched types:
 expected `&mut core::ops::FnMut() -> std::path::PathBuf`,
    found `[closure /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:237:42: 237:54]`
(expected &-ptr,
    found closure) [E0308]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:237             get_install_prefix_lib_path: || panic!(),
                                                                                                                                       ^~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:238:30: 238:45 error: the type of this value must be known in this context
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:238             realpath: |p| Ok(p.to_path_buf())
                                                                                                                           ^~~~~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:238:23: 238:46 error: mismatched types:
 expected `&mut for<'r> core::ops::FnMut(&'r std::path::Path) -> core::result::Result<std::path::PathBuf, std::io::error::Error>`,
    found `[closure /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:238:23: 238:46]`
(expected &-ptr,
    found closure) [E0308]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:238             realpath: |p| Ok(p.to_path_buf())

bors · 2015-03-04T17:20:58Z

☔ The latest upstream changes (presumably #22235) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2015-03-04T18:09:22Z

@bors: r=aturon cbb2ea1 p=1

bors · 2015-03-04T18:19:12Z

⌛ Testing commit cbb2ea1 with merge 0ccc0b8...

bors · 2015-03-04T19:59:09Z

💔 Test failed - auto-mac-32-opt

Manishearth · 2015-03-04T20:02:15Z

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:204:46: 204:58 error: mismatched types:
 expected `&mut core::ops::FnMut() -> std::path::PathBuf`,
    found `[closure /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:204:46: 204:58]`
(expected &-ptr,
    found closure) [E0308]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:204                 get_install_prefix_lib_path: || panic!(),
                                                                                                                                           ^~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:205:34: 205:49 error: the type of this value must be known in this context
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:205                 realpath: |p| Ok(p.to_path_buf())
                                                                                                                               ^~~~~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:205:27: 205:50 error: mismatched types:
 expected `&mut for<'r> core::ops::FnMut(&'r std::path::Path) -> core::result::Result<std::path::PathBuf, std::io::error::Error>`,
    found `[closure /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:205:27: 205:50]`
(expected &-ptr,
    found closure) [E0308]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/librustc_back/rpath.rs:205                 realpath: |p| Ok(p.to_path_buf())
                                                                                                                        ^~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to 3 previous errors
make: *** [i686-apple-darwin/stage2/test/rustc_backtest-i686-apple-darwin] Error 101

alexcrichton · 2015-03-04T20:58:20Z

@bors: r=aturon 4419219 p=1

This commit deprecates the majority of std::old_io::fs in favor of std::fs and its new functionality. Some functions remain non-deprecated but are now behind a feature gate called `old_fs`. These functions will be deprecated once suitable replacements have been implemented. The compiler has been migrated to new `std::fs` and `std::path` APIs where appropriate as part of this change. [breaking-change]

bors · 2015-03-04T21:51:50Z

⌛ Testing commit 4419219 with merge 37dbde9...

bors · 2015-03-04T23:31:30Z

💔 Test failed - auto-mac-32-opt

Manishearth · 2015-03-04T23:32:47Z

Bunch of lldb debuginfo failures


thread '[debuginfo-lldb] debuginfo/shadowed-argument.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/compiletest/runtest.rs:1483


---- [debuginfo-lldb] debuginfo/shadowed-variable.rs stdout ----
    NOTE: compiletest thinks it is using LLDB version 310

error: line not found in debugger output: [...]$0 = false
status: exit code: 0
command: "python" "/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/etc/lldb_batchmode.py" "i686-apple-darwin/test/debuginfo-lldb/shadowed-variable.stage2-i686-apple-darwin" "i686-apple-darwin/test/debuginfo-lldb/shadowed-variable.debugger.script"

This commit deprecates the majority of std::old_io::fs in favor of std::fs and its new functionality. Some functions remain non-deprecated but are now behind a feature gate called `old_fs`. These functions will be deprecated once suitable replacements have been implemented. The compiler has been migrated to new `std::fs` and `std::path` APIs where appropriate as part of this change.

alexcrichton · 2015-03-04T23:59:47Z

@bors: r=aturon 95d9046 p=1

bors · 2015-03-05T01:19:16Z

⌛ Testing commit 95d9046 with merge cc722a4...

This commit deprecates the majority of std::old_io::fs in favor of std::fs and its new functionality. Some functions remain non-deprecated but are now behind a feature gate called `old_fs`. These functions will be deprecated once suitable replacements have been implemented. The compiler has been migrated to new `std::fs` and `std::path` APIs where appropriate as part of this change. [breaking-change]

bors · 2015-03-05T04:32:48Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

eddyb · 2015-03-11T06:22:01Z

I see no explanation for the changes in pretty-printing, i.e. writing to a buffer and then saving that buffer to disk (or printing it out).
I guess I can work with that in #23017, if I move some things around... but I find it rather odd.

alexcrichton · 2015-03-11T18:35:14Z

@eddyb oh sorry about that, I initially didn't want to migrate the pretty printer just yet to the new I/O traits so it was easiest to just throw it all into a Vec and then print that to a std::fs::File for example. I wound up having to migrate the pretty printer, though, and I just forgot to go back and fixup what previously changed. Please feel free to revert back to what it previously was though!

rust-highfive assigned huonw Feb 27, 2015

aturon mentioned this pull request Feb 27, 2015

Stabilization for 1.0-beta #22500

Closed

91 tasks

alexcrichton force-pushed the deprecate-fs branch 4 times, most recently from 4d41a82 to 44af1b3 Compare February 27, 2015 23:07

alexcrichton force-pushed the deprecate-fs branch 3 times, most recently from 49ad452 to 6b9ad41 Compare February 28, 2015 02:25

alexcrichton force-pushed the deprecate-fs branch from 6b9ad41 to a389a66 Compare February 28, 2015 19:25

alexcrichton force-pushed the deprecate-fs branch 2 times, most recently from a16abfc to b10b656 Compare March 2, 2015 17:05

aturon reviewed Mar 2, 2015
View reviewed changes

alexcrichton force-pushed the deprecate-fs branch from b10b656 to b30b276 Compare March 2, 2015 23:27

alexcrichton force-pushed the deprecate-fs branch from 0daf8ca to cbb2ea1 Compare March 4, 2015 18:09

alexcrichton force-pushed the deprecate-fs branch from cbb2ea1 to 4419219 Compare March 4, 2015 20:58

alexcrichton force-pushed the deprecate-fs branch from 4419219 to 95d9046 Compare March 4, 2015 23:59

bors merged commit 95d9046 into rust-lang:master Mar 5, 2015

This was referenced Mar 5, 2015

overloaded-box protocol changes #22086

Closed

If while let multiple patterns #23034

Closed

alexcrichton deleted the deprecate-fs branch March 11, 2015 18:34

ErikBjare mentioned this pull request Feb 25, 2017

JSON Schema example no longer works s-panferov/valico#25

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std: Deprecate std::old_io::fs #22873

std: Deprecate std::old_io::fs #22873

alexcrichton commented Feb 27, 2015

rust-highfive commented Feb 27, 2015

huonw commented Feb 28, 2015

alexcrichton commented Feb 28, 2015

bors commented Feb 28, 2015

bors commented Mar 1, 2015

aturon Mar 2, 2015

alexcrichton Mar 2, 2015

aturon commented Mar 2, 2015

alexcrichton commented Mar 2, 2015

alexcrichton commented Mar 2, 2015

bors commented Mar 2, 2015

bors commented Mar 2, 2015

alexcrichton commented Mar 2, 2015

bors commented Mar 3, 2015

bors commented Mar 4, 2015

bors commented Mar 4, 2015

Manishearth commented Mar 4, 2015

bors commented Mar 4, 2015

alexcrichton commented Mar 4, 2015

bors commented Mar 4, 2015

bors commented Mar 4, 2015

Manishearth commented Mar 4, 2015

alexcrichton commented Mar 4, 2015

bors commented Mar 4, 2015

bors commented Mar 4, 2015

Manishearth commented Mar 4, 2015

alexcrichton commented Mar 4, 2015

bors commented Mar 5, 2015

bors commented Mar 5, 2015

eddyb commented Mar 11, 2015

alexcrichton commented Mar 11, 2015

std: Deprecate std::old_io::fs #22873

std: Deprecate std::old_io::fs #22873

Conversation

alexcrichton commented Feb 27, 2015

rust-highfive commented Feb 27, 2015

huonw commented Feb 28, 2015

alexcrichton commented Feb 28, 2015

bors commented Feb 28, 2015

bors commented Mar 1, 2015

aturon Mar 2, 2015

Choose a reason for hiding this comment

alexcrichton Mar 2, 2015

Choose a reason for hiding this comment

aturon commented Mar 2, 2015

alexcrichton commented Mar 2, 2015

alexcrichton commented Mar 2, 2015

bors commented Mar 2, 2015

bors commented Mar 2, 2015

alexcrichton commented Mar 2, 2015

bors commented Mar 3, 2015

bors commented Mar 4, 2015

bors commented Mar 4, 2015

Manishearth commented Mar 4, 2015

bors commented Mar 4, 2015

alexcrichton commented Mar 4, 2015

bors commented Mar 4, 2015

bors commented Mar 4, 2015

Manishearth commented Mar 4, 2015

alexcrichton commented Mar 4, 2015

bors commented Mar 4, 2015

bors commented Mar 4, 2015

Manishearth commented Mar 4, 2015

alexcrichton commented Mar 4, 2015

bors commented Mar 5, 2015

bors commented Mar 5, 2015

eddyb commented Mar 11, 2015

alexcrichton commented Mar 11, 2015