Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of PRs in the queue; Saturday #22895

Merged
merged 14 commits into from
Feb 28, 2015
Merged

Rollup of PRs in the queue; Saturday #22895

merged 14 commits into from
Feb 28, 2015

Conversation

Manishearth
Copy link
Member

iKevinY and others added 13 commits February 27, 2015 03:13
The format of `rustc --version` was changed in rust-lang#21957.
MacEager is a MacResult implementation for the common case where you've already
built each form of AST that you might return.

Fixes rust-lang#17637. Based on rust-lang#18814.

This is a [breaking-change] for syntax extensions:

  * MacExpr::new becomes MacEager::expr.

  * MacPat::new becomes MacEager::pat.

  * MacItems::new becomes MacEager::items. It takes a SmallVector directly,
    not an iterator.
Now that the `std::env` module has had some time to bake this commit marks most
of its APIs as `#[stable]`. Some notable APIs that are **not** stable (and still
use the same `env` feature gate) are:

* `{set,get}_exit_status` - there are still questions about whether this is the
  right interface for setting/getting the exit status of a process.
* `page_size` - this may change location in the future or perhaps name as well.

This also effectively closes rust-lang#22122 as the variants of `VarError` are
`#[stable]` now. (this is done intentionally)
 Now that the `std::env` module has had some time to bake this commit marks most
of its APIs as `#[stable]`. Some notable APIs that are **not** stable (and still
use the same `env` feature gate) are:

* `{set,get}_exit_status` - there are still questions about whether this is the
  right interface for setting/getting the exit status of a process.
* `page_size` - this may change location in the future or perhaps name as well.

This also effectively closes rust-lang#22122 as the variants of `VarError` are
`#[stable]` now. (this is done intentionally)
 MacEager is a MacResult implementation for the common case where you've already built each form of AST that you might return.

Fixes rust-lang#17637. Based on rust-lang#18814.

This is a [breaking-change] for syntax extensions:

  * MacExpr::new becomes MacEager::expr.

  * MacPat::new becomes MacEager::pat.

  * MacItems::new becomes MacEager::items. It takes a SmallVector directly,
    not an iterator.

r? @sfackler
 This is leftover from rust-lang#21843

If you still have `|&:| {}` closures in your code, simply remove the `&:` part.

[breaking-change]
…anishearth

 The format of `rustc --version` was changed in rust-lang#21957; this PR updates TRPL accordingly.
 Updated the function to allow comparisons between different types since PartialOrd and PartialEq allow this.
@Manishearth
Copy link
Member Author

@bors: p=20 r+

@bors
Copy link
Contributor

bors commented Feb 28, 2015

@bors r=Manishearth 0775959

@Manishearth
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Feb 28, 2015

⌛ Testing commit 0775959 with merge 8a69110...

@bors bors merged commit 0775959 into rust-lang:master Feb 28, 2015
@Manishearth Manishearth deleted the rollup branch February 28, 2015 16:19
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants