Minor refactoring/modernization/reintegration/enhancement of --pretty. #23017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -> Option<(PpMode, Option<UserIdentifiedItem>)> { | ||
| None | ||
| } | ||
|
|
|
r+ on the driver refactoring. Afraid I don't know the pretty printing stuff well enough to comment, so r? @pnkfelix for that |
… pretty-printing annotators.
… pretty_print_input.
… T)`, as the latter might compile some day.
…ntroller manually.
…--xpretty=mode -Z pretty-keep-going -Z pretty-dump-dir=dir.
|
☔ The latest upstream changes (presumably #22235) made this pull request unmergeable. Please resolve the merge conflicts. |
|
(i'm going to be out until wedneday; but I will try to get to this then. sorry for the absurd delay; maybe you can rebase in the meantime @eddyb ) |
|
@nrc you would want to at least drop the last commit (there are better ways to handle this than env vars), and @alexcrichton changed pretty to do some I/O buffering at some point, that has to be reverted first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: explain the new options.
Adds
-Z pretty-keep-going,-Z pretty-dump-dir=dir,--xpretty=typed,unsuffixed_literalsandRUSTC_PRETTY_DUMP=mode,dir.These features made #22501 possible and if/when they get into a nightly, we can apply it to all cargo crates ever, even if only to gather statistics.
r? @nrc @pnkfelix