Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net::tcp::tests::fast_rebind test occasionally fails #57509

Closed
nnethercote opened this issue Jan 11, 2019 · 1 comment · Fixed by #67308
Closed

net::tcp::tests::fast_rebind test occasionally fails #57509

nnethercote opened this issue Jan 11, 2019 · 1 comment · Fixed by #67308
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@nnethercote
Copy link
Contributor

nnethercote commented Jan 11, 2019 •
edited
Loading

I've seen it fail a couple of times on my Ubuntu 18.04 box.

The only other evidence of failure I can find after searching online is here: #25172 (comment)
@estebank estebank added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 11, 2019
@dtolnay
Copy link
Member

dtolnay commented Dec 15, 2019

It fails relatively frequently for me on Linux, maybe 1 out of 4 times.

---- net::tcp::tests::fast_rebind stdout ----
thread '<unnamed>' panicked at 'received error for `TcpListener::bind(&addr)`: Address already in use (os error 98)', src/libstd/net/tcp.rs:1326:13


failures:
    net::tcp::tests::fast_rebind

It looks like someone else has observed it failing on macOS as well: #51006. I think I will send a PR to delete the test.

@dtolnay dtolnay mentioned this issue Dec 15, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Dec 16, 2019
@Centril
Rollup merge of rust-lang#67308 - dtolnay:fast_rebind, r=alexcrichton
f9e1d3b 
Delete flaky test net::tcp::tests::fast_rebind

This test is unreliable for at least 3 users on two platforms: see rust-lang#57509 and rust-lang#51006. It was added 5 years ago in rust-lang#22015. Do we know whether this is testing something important that would indicate a bug in our implementation, or if it's fine to remove?

r? @sfackler @alexcrichton because this somewhat resembles rust-lang#59018

Closes rust-lang#57509. Closes rust-lang#51006.
@bors bors closed this as completed in a1580e7 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete flaky test net::tcp::tests::fast_rebind dtolnay/rust
3 participants
@estebank @nnethercote @dtolnay