Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test failures on macOS #51006

Closed
matthewbauer opened this issue May 23, 2018 · 0 comments · Fixed by #67308
Closed

Random test failures on macOS #51006

matthewbauer opened this issue May 23, 2018 · 0 comments · Fixed by #67308
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-macos Operating system: macOS

Comments

@matthewbauer
Copy link

matthewbauer commented May 23, 2018 •
edited
Loading

We have run into a few problems on building Rustc for macOS with Nixpkgs. A few network tests seem to fail randomly. It's about 1 in every 10 tests that fail without any obvious reason.

Job: https://hydra.nixos.org/job/nixpkgs/trunk/rustc.x86_64-darwin/all

It's possible it's hardware related but has not happened on the Linux builds. Here is the full list of temperamental tests:

  • net::tcp::tests::clone_while_reading
  • net::tcp::tests::multiple_connect_interleaved_greedy_schedule
  • net::tcp::tests::multiple_connect_interleaved_lazy_schedule
  • net::tcp::tests::partial_read
  • net::tcp::tests::read_eof
  • net::tcp::tests::shutdown_smoke
  • net::tcp::tests::tcp_clone_two_read
  • net::tcp::tests::clone_accept_smoke
  • run-make/issue-26092

Most of the network ones are "Address already in use":

thread '<unnamed>' panicked at 'received error for `TcpListener::bind(&addr)`: Address already in use (os error 48)', libstd/net/tcp.rs:1377:26
@Mark-Simulacrum Mark-Simulacrum added A-testsuite Area: The testsuite used to check the correctness of rustc O-macos Operating system: macOS C-bug Category: This is a bug. labels May 24, 2018
matthewbauer added a commit to NixOS/nixpkgs that referenced this issue Jun 3, 2018
@matthewbauer
rust: disable tests on darwin
332b9de 
See rust-lang/rust#51006

Tests frequently fail on Darwin. Not sure why but it's easier to just disable for now.
This was referenced Dec 15, 2019
Closed
Merged
Centril added a commit to Centril/rust that referenced this issue Dec 16, 2019
@Centril
Rollup merge of rust-lang#67308 - dtolnay:fast_rebind, r=alexcrichton
f9e1d3b 
Delete flaky test net::tcp::tests::fast_rebind

This test is unreliable for at least 3 users on two platforms: see rust-lang#57509 and rust-lang#51006. It was added 5 years ago in rust-lang#22015. Do we know whether this is testing something important that would indicate a bug in our implementation, or if it's fine to remove?

r? @sfackler @alexcrichton because this somewhat resembles rust-lang#59018

Closes rust-lang#57509. Closes rust-lang#51006.
@bors bors closed this as completed in a1580e7 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-macos Operating system: macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete flaky test net::tcp::tests::fast_rebind dtolnay/rust
2 participants
@matthewbauer @Mark-Simulacrum