std: Add a net module for TCP/UDP
#22015
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Note that this is an in progress implementation of rust-lang/rfcs#807 and should not be merged until the RFC is merge. All future updates to the RFC will be merged in here as well. r? @aturon |
|
|
||
| // //////////////////////////////////////////////////////////////////////////////// | ||
| // // get_address_name | ||
| // //////////////////////////////////////////////////////////////////////////////// |
There was a problem hiding this comment.
Is this intentionally left here? Should it be deleted?
There was a problem hiding this comment.
Oops, meant to delete this.
|
👍 looks good to me. As I discussed a/ @alexcrichton, I believe that the only blocker for me to remove my re-impl of the net types with this is being able to construct the various types (listener, stream, ...) from an FD. The reason that I need this is, as mentioned in the RFC, more advanced pre-configuration of the socket types is being deferred. I (and other mio users) really need to be able to do more than what is exposed. An escape valve is being able to construct the types from an FD and get the FD from the types (getting is already possible). All that would be left is allowing construction of the various types from the FD. |
alexcrichton
force-pushed
the
netv2
branch
3 times, most recently
from
a51a03d to
3e6b4af
Compare
| SocketAddr { repr: Repr::V4(addr) } | ||
| } | ||
| } | ||
| impl FromInner<libc::sockaddr_in6> for SocketAddr { |
alexcrichton
force-pushed
the
netv2
branch
2 times, most recently
from
e284394 to
e030074
Compare
| /// A trait for objects which can be converted or resolved to one or more | ||
| /// `SocketAddr` values. | ||
| /// | ||
| /// This trait is used for generic address resolution when constructing network |
|
I'm basically happy with this PR. I left a couple of minor nits, mostly bikeshedding. |
|
@carllerche Yes, we need to tackle raw creation soon, though that will be needed across all of new IO. Should be easy to do. |
This commit is an implementation of [RFC 807][rfc] which adds a `std::net` module for basic neworking based on top of `std::io`. This module serves as a replacement for the `std::old_io::net` module and networking primitives in `old_io`. [rfc]: fillmein The major focus of this redesign is to cut back on the level of abstraction to the point that each of the networking types is just a bare socket. To this end functionality such as timeouts and cloning has been removed (although cloning can be done through `duplicate`, it may just yield an error). With this `net` module comes a new implementation of `SocketAddr` and `IpAddr`. This work is entirely based on rust-lang#20785 and the only changes were to alter the in-memory representation to match the `libc`-expected variants and to move from public fields to accessors.
|
Updated with nits addressed. |
This commit is an implementation of [RFC 807][rfc] which adds a `std::net` module for basic neworking based on top of `std::io`. This module serves as a replacement for the `std::old_io::net` module and networking primitives in `old_io`. [rfc]: fillmein The major focus of this redesign is to cut back on the level of abstraction to the point that each of the networking types is just a bare socket. To this end functionality such as timeouts and cloning has been removed (although cloning can be done through `duplicate`, it may just yield an error). With this `net` module comes a new implementation of `SocketAddr` and `IpAddr`. This work is entirely based on rust-lang#20785 and the only changes were to alter the in-memory representation to match the `libc`-expected variants and to move from public fields to accessors.
|
⌛ Testing commit 395709c with merge 312627b... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry |
The alleged implementation of this RFC in <rust-lang/rust#22015> included `try_clone` rather than `duplicate`. This commit updates the approved RFC to match the actual implementation.
Delete flaky test net::tcp::tests::fast_rebind This test is unreliable for at least 3 users on two platforms: see rust-lang#57509 and rust-lang#51006. It was added 5 years ago in rust-lang#22015. Do we know whether this is testing something important that would indicate a bug in our implementation, or if it's fine to remove? r? @sfackler @alexcrichton because this somewhat resembles rust-lang#59018 Closes rust-lang#57509. Closes rust-lang#51006.
Delete flaky test net::tcp::tests::fast_rebind This test is unreliable for at least 3 users on two platforms: see rust-lang#57509 and rust-lang#51006. It was added 5 years ago in rust-lang#22015. Do we know whether this is testing something important that would indicate a bug in our implementation, or if it's fine to remove? r? @sfackler @alexcrichton because this somewhat resembles rust-lang#59018 Closes rust-lang#57509. Closes rust-lang#51006.
This commit is an implementation of RFC 807 which adds a
std::netmodule for basic neworking based on top of
std::io. This module serves as areplacement for the
std::old_io::netmodule and networking primitives inold_io.The major focus of this redesign is to cut back on the level of abstraction to
the point that each of the networking types is just a bare socket. To this end
functionality such as timeouts and cloning has been removed (although cloning
can be done through
duplicate, it may just yield an error).With this
netmodule comes a new implementation ofSocketAddrandIpAddr.This work is entirely based on #20785 and the only changes were to alter the
in-memory representation to match the
libc-expected variants and to move frompublic fields to accessors.