Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex tests are ignored on windows #13725

Closed
alexcrichton opened this issue Apr 24, 2014 · 5 comments
Closed

Regex tests are ignored on windows #13725

alexcrichton opened this issue Apr 24, 2014 · 5 comments
Labels
O-windows Operating system: Windows

Comments

@alexcrichton
Copy link
Member

Updated description

They're broken on the bots: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5537/steps/test/logs/stdio

Needs investigation.

Original description

For example, the new regex tests just failed with this error

C:\bot\slave\auto-win-32-nopt-t\build\src\libregex\test\mod.rs:13:1: 13:27 error: Error code 127
C:\bot\slave\auto-win-32-nopt-t\build\src\libregex\test\mod.rs:13 extern crate regex_macros;
                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~

I suspect that we're not marking the macro registrar with a dllexport linkage. Needs more investigation.

Additionally, that error is pretty bad.

@alexcrichton
Copy link
Member Author

@alexcrichton
Copy link
Member Author

I am less convinced that this is a syntax extension problem (small syntax extensions work for me), requires more investigation.

@alexcrichton
Copy link
Member Author

Closing, the underlying cause is on osx as well, this will get fixed anyway when landing regexes.

@alexcrichton alexcrichton changed the title Syntax extensions are suspected to not work on windows Regex tests are ignored on windows Apr 25, 2014
@alexcrichton
Copy link
Member Author

Reopening and hijacking the description.

@alexcrichton alexcrichton reopened this Apr 25, 2014
@luqmana
Copy link
Member

luqmana commented Jun 4, 2014

I just tried running make check-stage2-cfail-full TESTNAME=syntax-extension-regex-invalid after removing the ignore line and it seems to work fine:

Nam@Nam-PC ~/rust/build
$ make check-stage2-cfail-full TESTNAME=syntax-extension-regex-invalid
cfg: build triple i686-pc-mingw32
cfg: host triples i686-pc-mingw32
cfg: target triples i686-pc-mingw32
cfg: enabling more debugging (CFG_ENABLE_DEBUG)
cfg: host for i686-pc-mingw32 is i386
cfg: os for i686-pc-mingw32 is pc-mingw32
cfg: using CC=gcc (CFG_CC)
cfg: disabling valgrind due to its unreliability on this platform
/home/Nam/rust/mk/stage0.mk:7: warning: overriding recipe for target 'i686-pc-mingw32/stage0/bin/'
/home/Nam/rust/mk/stage0.mk:4: warning: ignoring old recipe for target 'i686-pc-mingw32/stage0/bin/'
cfg: no pdflatex found, deferring to xelatex
cfg: no xelatex found, deferring to lualatex
cfg: no lualatex found, disabling LaTeX docs
cfg: no pandoc found, omitting PDF and EPUB docs
cfg: no llnextgen found, omitting grammar-verification
cfg: disabling doc build (CFG_DISABLE_DOCS)
cfg: including test rules
run cfail-full [i686-pc-mingw32]: i686-pc-mingw32/stage2/bin/compiletest.exe

running 1 test
test [compile-fail] compile-fail-fulldeps/syntax-extension-regex-invalid.rs ... ok

using metrics ratchet: tmp\check-stage2-T-i686-pc-mingw32-H-i686-pc-mingw32-cfail-full-metrics.json
result of ratchet: 0 metrics added, 0 removed, 0 improved, 0 regressed, 0 noise
updated ratchet file

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured

@brson brson mentioned this issue Aug 12, 2014
33 tasks
bors added a commit that referenced this issue Aug 18, 2014
First commit enables regex test on Windows. It was not working at some point (#13725), but it works now.

Second commit removes various FIXMEs regarding #13793, since upstream bug has been fixed.
@bors bors closed this as completed in d7916f8 Aug 18, 2014
arcnmx pushed a commit to arcnmx/rust that referenced this issue Dec 17, 2022
…flodiebold

feat: resolve const for trait impls

Fixed rust-lang#13694
arcnmx pushed a commit to arcnmx/rust that referenced this issue Dec 17, 2022
…esult, r=Veykril

fix: resolve all inference vars in `InferenceResult::assoc_resolutions`

I think this fixes 'rust-lang#13773, ~but still haven't found repro. I'll try finding one so we can have a regression test~.

We should resolve every inference variable in `InferenceResult` after inference is done. We started recording `Substitution`s for each resolved associated items in rust-lang#13725, but failed to do so which causes crash when analyzing source in IDE layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

2 participants