Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace many uses of ~ with box. #11779 #13773

Merged
merged 2 commits into from
May 3, 2014
Merged

Replace many uses of ~ with box. #11779 #13773

merged 2 commits into from
May 3, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 26, 2014

box is the way you allocate in future-rust.

@brson
Copy link
Contributor Author

brson commented Apr 26, 2014

I'll point out that this is a pretty small diff, which I think is a good indication this is the right direction.

bors added a commit that referenced this pull request May 3, 2014
`box` is the way you allocate in future-rust.
@nikomatsakis
Copy link
Contributor

nice.

@bors bors closed this May 3, 2014
@bors bors merged commit a5be12c into rust-lang:master May 3, 2014
arcnmx pushed a commit to arcnmx/rust that referenced this pull request Dec 17, 2022
…esult, r=Veykril

fix: resolve all inference vars in `InferenceResult::assoc_resolutions`

I think this fixes 'rust-lang#13773, ~but still haven't found repro. I'll try finding one so we can have a regression test~.

We should resolve every inference variable in `InferenceResult` after inference is done. We started recording `Substitution`s for each resolved associated items in rust-lang#13725, but failed to do so which causes crash when analyzing source in IDE layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants