Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows metabug #16459

Closed
28 of 33 tasks
brson opened this issue Aug 12, 2014 · 13 comments
Closed
28 of 33 tasks

Windows metabug #16459

brson opened this issue Aug 12, 2014 · 13 comments
Assignees
Labels
metabug Issues about issues themselves ("bugs about bugs") O-windows Operating system: Windows

Comments

@brson
Copy link
Contributor

brson commented Aug 12, 2014

These are some of the major outstanding Windows bugs, ordered roughly by priority. Prior discussion

Major tasks:

Compiler fixes:

Library fixes:

Mysterious crashes:

Other:

@brson brson self-assigned this Aug 12, 2014
@emberian
Copy link
Member

Somewhat unrelated, but I've started work on a Visual Studio extension as well.

@tomaka
Copy link
Contributor

tomaka commented Aug 12, 2014

Note that I've started encountering random crashes on Windows for one of my programs after I switched from using a (native) task to using a std::rt::thread, even though the task was not using I/O at all. Switching back to using a task fixed everything.

I didn't report it because it's very vague and I couldn't reproduce the issue reliably (I spent one or two hours trying to), but there's definitely something wrong with std::rt::thread that doesn't seem to be on this list.

@vadimcn
Copy link
Contributor

vadimcn commented Aug 15, 2014

Given that we don't want users to have to install msys/mingw, does it even make sense to worry about 'make install' (#13810)?

@ghost
Copy link

ghost commented Aug 20, 2014

@vadimcn
Worrying about make install makes sense, as a person might prefer compiling rust with the defaults [though it surely is not high priority] and :-

  1. Someone might want to compile rust him/herself maybe for cross-compilation.
  2. Someone might want to contribute to the rust windows code-base but he might want to make sure if his changes work as expected.
  3. etc. etc.

@retep998
Copy link
Member

I just point my PATH at the x86_64-w64-mingw32\stage2\bin folder and I'm able to compile programs with that rustc. I never trust make install on Windows anyway since I have no idea where it will install.

@vadimcn
Copy link
Contributor

vadimcn commented Aug 20, 2014

@V01D-exe, yes it might be useful. But should it be on the list of v1.0 blockers? I think not.

@ghost
Copy link

ghost commented Aug 21, 2014

@vadimcn
Agreed, it should be low-priority as of now.
Later on [maybe after about 1 year ], when rust is stable and windows support becomes properly mature [i.e. no major bugs in the binaries] , then it would be high priority.

Till then, it would be better to modify the windows compilation instructions in readme.md and remove && make install from the last command. Even better to include a note about the current not-working status of make install over there, so that people know that it is bugged. And maybe even better to add retep998's instructions posted above.

@brson
Copy link
Contributor Author

brson commented Aug 22, 2014

Nominating. Many of these sub-bugs should be fixed for 1.0.

@iliekturtles
Copy link
Contributor

The nightly installer isn't adding C:\Program Files (x86)\Rust\bin to PATH as the installer advertises. I couldn't find an existing issue. Should one be opened or am I doing something wrong?

@brson
Copy link
Contributor Author

brson commented Sep 26, 2014

@iliekturtles Please open an issue, yes.

@iliekturtles
Copy link
Contributor

@brson #17570 opened for discussion. Will submit a patch for one of the proposed solutions shortly.

@alexcrichton alexcrichton added A-metadata Area: Crate metadata metabug Issues about issues themselves ("bugs about bugs") and removed A-metadata Area: Crate metadata labels Jan 20, 2015
@frewsxcv
Copy link
Member

Visiting for triage: Any updates for any of the items above?

@alexcrichton
Copy link
Member

Enough of this has been checked off that I think it's safe to say this can be closed now.

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Feb 5, 2024
internal: Use improved adjusted_display_range for all diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metabug Issues about issues themselves ("bugs about bugs") O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

8 participants