-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement playground-specific custom metadata to control enabled features #326
Conversation
Using cargo from git because the developers are in the process of figuring out how to align their version numbers with rustc and may need to skip the next one or two releases. The Manifest::custom_metadata method is new in master and will be required for supporting playground-specific custom metadata.
} | ||
} | ||
|
||
fn is_true(b: &bool) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh
As when you added the original feature support: wow, thanks! Do you think the metadata should completely replace the |
Yes I think custom metadata completely replaces our earlier scheme of looking for a For now the |
Yeah, I agree with everything you said. I'll wait just a while to see what the UUID devs have to say; I think they added that comparatively recently. |
In uuid-rs/uuid#224 it looks like they are good with it. That person reviewed the original change in uuid-rs/uuid#189. |
Yes, I would love this change... Just a note: the original uuid PR for this was uuid-rs/uuid#155 |
Forward to the future! |
224: Use custom metadata to specify playground features r=kinggoesgaming a=dtolnay Fixes #223. Marking WIP until rust-lang/rust-playground#326 has landed. Co-authored-by: David Tolnay <[email protected]>
This is based on the custom metadata configurable for docs.rs -- see https://docs.rs/about. Ours looks like:
This PR includes a bump of the Cargo dependency to pick up rust-lang/cargo#5360 which has not been included in a release yet.
Motivation
I want the
"extra-traits"
feature of Syn so that people can debug print a syntax tree. This comes up often in IRC.