Remove enabling a "playground" feature #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "playground" feature is superseded by Cargo.toml custom metadata.
shepmaster
reviewed
May 12, 2018
|
|
||
| Method::Required { | ||
| dev_deps: false, | ||
| features: Box::leak(Box::new(features)), |
There was a problem hiding this comment.
Whew, that was in there for too long!
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "playground" feature is superseded by Cargo.toml custom metadata from #326.
The last of the top 100 crates still using this feature is uuid. I have a PR open in uuid-rs/uuid#224 to move them to custom metadata. I don't think we need to wait for them because the playground feature doesn't do what they want anyway. The features were enabled during transitive dependency resolution but not in the Cargo.toml generated by top-crates. For example see this playground which shows uuid's
"serde"feature not enabled despite being listed as a playground feature here.