Preserve package.metadata when packaging
#4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we use Serde this is actually trivial to implement! Closes rust-lang#4142
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @matklad |
matklad
reviewed
Jun 14, 2017
| @@ -109,9 +109,7 @@ pub fn to_manifest(contents: &str, | |||
| let manifest: TomlManifest = serde_ignored::deserialize(root, |path| { | |||
| let mut key = String::new(); | |||
| stringify(&mut key, &path); | |||
| if !key.starts_with("package.metadata") { | |||
There was a problem hiding this comment.
Hm, I think this if is intentional to avoid warning about "key metadata is unused". Do we want to start issuing this warning?
There was a problem hiding this comment.
It is indeed intentional! Note though that these keys are now all considered used because they're decoded directly into the manifest, so they won't show up here any more.
|
#bors r+ |
|
@bors r+ |
|
📌 Commit 0c704f8 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 14, 2017
Preserve `package.metadata` when packaging Now that we use Serde this is actually trivial to implement! Closes #4142
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use Serde this is actually trivial to implement!
Closes #4142