This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Always pass the --all flag when needed
#7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
remove_bundle_update_deprecations
branch
from
8c5dfc4 to
0bc4970
Compare
|
Another standard PR removing deprecations from our specs, merging in! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 1, 2019
7080: Always pass the `--all` flag when needed r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that some specs were still using `bundle update` to update all gems, which is deprecated. ### What is your fix for the problem, implemented in this PR? My fix is to update all specs to use the new preferred command, namely, `bundle update --all`. Co-authored-by: David Rodríguez <[email protected]>
Build succeeded |
ghost
merged commit
colby-swandale
pushed a commit
that referenced
this pull request
Apr 8, 2019
7080: Always pass the `--all` flag when needed r=deivid-rodriguez a=deivid-rodriguez The problem was that some specs were still using `bundle update` to update all gems, which is deprecated. My fix is to update all specs to use the new preferred command, namely, `bundle update --all`. Co-authored-by: David Rodríguez <[email protected]> (cherry picked from commit 63cc70a) (cherry picked from commit e423c83f1f6bccbfc992bca7aef2ad31d6449d75)
colby-swandale
added a commit
that referenced
this pull request
Jun 13, 2019
* 2-0-stable: (89 commits) fix changelog 2.0.2 typos add v2.0.2 changelog bump version to 2.0.2 Merge #7199 fix bug where bundler v3 is running a test for bundflet 2 Merge #6798 add bors configuation port GemHelper from master Merge #7080 Merge #7089 Merge #7068 Merge #7036 Merge #7067 change Bundler 3 specs in travis to use RubyGems 3.0.3 bump RubyGems v3 to the latest version on Travis Merge #6963 Merge #7078 Merge pull request #7061 from bundler/fix_circular_requires Merge #6864 remove linting step in travis (it will still run in each build) ...
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that some specs were still using
bundle updateto update all gems, which is deprecated.What is your fix for the problem, implemented in this PR?
My fix is to update all specs to use the new preferred command, namely,
bundle update --all.